Skip to content

test: One liner to skip read_table_version_hdfs #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

test: One liner to skip read_table_version_hdfs #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27aa06
[Adhoc] One liner to skip read_table_version_hdfs
sanujbasu Oct 27, 2025
88d0cb7
[Adhoc] Fixed the README not to suggest rust analyzer config changes
sanujbasu Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,7 @@ Some design principles which should be considered:
- If using `emacs`, both [eglot](https://github.com/joaotavora/eglot) and
[lsp-mode](https://github.com/emacs-lsp/lsp-mode) provide excellent integration with
`rust-analyzer`. [rustic](https://github.com/brotzeit/rustic) is a nice mode as well.
- When also developing in VS Code it's sometimes convenient to configure rust-analyzer in
`.vscode/settings.json`.

```json
{
"editor.formatOnSave": true,
"rust-analyzer.cargo.features": ["default-engine"]
}
```
- When also developing in VS Code it's convenient to add rust-analyzer to your workspace.

- The crate's documentation can be easily reviewed with: `cargo docs --open`
- Code coverage is available on codecov via [cargo-llvm-cov]. See their docs for instructions to install/run locally.
Expand Down
1 change: 1 addition & 0 deletions kernel/tests/hdfs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ async fn write_local_path_to_hdfs(
}

#[tokio::test]
#[ignore = "Skipping HDFS integration test"]
Copy link
Collaborator

@emkornfield emkornfield Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check to CI to see if there is anyplace where this test is not being skipped, so it can be run explicitly.

Copy link
Collaborator Author

@sanujbasu sanujbasu Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack.
1/ Validated the CI

https://github.com/delta-io/delta-kernel-rs/blob/5058bce725f5fce39e5f33f09ec9445cdd0ea7eb/.github/workflows/build.yml#L131

2/ IIUC the test can be explicitly run by requesting the ignored test to be run with the apt feature flag set. Validated

➜  delta-kernel-rs git:(skiptest) cargo test --features integration-test --test hdfs -- --ignored --list
   Compiling parquet v56.2.0
   Compiling delta_kernel v0.16.0 (/Users/sanuj.basu/KernelSource/delta-kernel-rs/kernel)
   Compiling test_utils v0.16.0 (/Users/sanuj.basu/KernelSource/delta-kernel-rs/test-utils)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 6.30s
     Running tests/hdfs.rs (target/debug/deps/hdfs-bdd8c212ac20f512)
read_table_version_hdfs: test

 delta-kernel-rs git:(skiptest) cargo test --features integration-test --test hdfs -- --include-ignored
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.19s
     Running tests/hdfs.rs (target/debug/deps/hdfs-bdd8c212ac20f512)

running 1 test
test read_table_version_hdfs ... FAILED

failures:

---- read_table_version_hdfs stdout ----

thread 'read_table_version_hdfs' panicked at /Users/sanuj.basu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hdfs-native-0.12.3/src/minidfs.rs:59:37:
Failed to find mvn executable: CannotFindBinaryPath
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    read_table_version_hdfs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

error: test failed, to rerun pass `-p delta_kernel --test hdfs`

Copy link
Collaborator

@emkornfield emkornfield Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicklan should we just delete this test if we don't have CI coverage for it? Are there plans to add CI coverage?

async fn read_table_version_hdfs() -> Result<(), Box<dyn std::error::Error>> {
let minidfs = MiniDfs::with_features(&HashSet::new());
let hdfs_client = Client::default();
Expand Down
Loading