-
Notifications
You must be signed in to change notification settings - Fork 119
refactor: simplify creation of default engine in tests #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 84.85% 84.85% -0.01%
==========================================
Files 119 119
Lines 30961 30952 -9
Branches 30961 30952 -9
==========================================
- Hits 26271 26263 -8
+ Misses 3408 3406 -2
- Partials 1282 1283 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DrakeLin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nicklan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What changes are proposed in this pull request?
Unit tests have accumulated myriad ways of creating a new default engine instance. Harmonize and simplify them.
Breaking changes
parse_url_optswas renamed asstore_from_url_optsDefaultEngine::try_newwas removed.DefaultEngine::newsignature changed.How was this change tested?
Test-only change.