chore: make tests async if they rely on async #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scovich
commented
Oct 29, 2025
| LogPathFileType::MultiPartCheckpoint { | ||
| part_num, | ||
| num_parts, | ||
| } => { |
There was a problem hiding this comment.
NOTE: This PR is best review with whitespace ignored, so these big indentation changes don't clutter the diff.
scovich
commented
Oct 29, 2025
Comment on lines
+60
to
+61
| #[tokio::test] | ||
| async fn test_create_checkpoint_metadata_batch() -> DeltaResult<()> { |
There was a problem hiding this comment.
The changes in this PR are extremely mechanical: add async, .await, and #[tokio::test] annotations... plus cargo fmt and indentation noise.
github-actions
bot
added
the
breaking-change
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
+ Coverage 84.85% 85.32% +0.47%
==========================================
Files 119 119
Lines 30961 32336 +1375
Branches 30961 32336 +1375
==========================================
+ Hits 26271 27590 +1319
- Misses 3408 3413 +5
- Partials 1282 1333 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
A whole bunch of unit tests are async code masquerading as sync, by various hacks to obtain an executor and block on futures produced by object_store and parquet calls. Clean up the mess by plumbing async through as appropriate.
How was this change tested?
Test-only change.