Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

@DrakeLin DrakeLin commented Oct 29, 2025

What changes are proposed in this pull request?

Fixes #1431 by post-processing JSON output to strip ".0" suffix from Decimal columns with scale=0.

How was this change tested?

new unit test

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 91.08911% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.87%. Comparing base (70143ca) to head (986d097).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...src/engine/arrow_expression/evaluate_expression.rs 91.08% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   84.85%   84.87%   +0.01%     
==========================================
  Files         119      119              
  Lines       30961    31061     +100     
  Branches    30961    31061     +100     
==========================================
+ Hits        26271    26362      +91     
- Misses       3408     3413       +5     
- Partials     1282     1286       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DrakeLin DrakeLin changed the title fix: post-process decimal fields in Arrow encoder fix: post-process scale-0 decimals in JSON stats with regex Oct 29, 2025
@DrakeLin DrakeLin closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot create tables with Decimal, scale=0

1 participant