feat: enable writes to CDF enabled tables only if append only is supported #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 84.84% 84.92% +0.07%
==========================================
Files 119 119
Lines 31031 31152 +121
Branches 31031 31152 +121
==========================================
+ Hits 26329 26455 +126
+ Misses 3425 3421 -4
+ Partials 1277 1276 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklan
approved these changes
Nov 4, 2025
kernel/src/table_configuration.rs
Outdated
| &["delta.enableChangeDataFeed", "delta.appendOnly"], | ||
| &[ChangeDataFeed, ColumnMapping, AppendOnly], | ||
| ), | ||
| Err(Error::unsupported(r#"Unknown TableFeatures: "columnMapping". Supported TableFeatures: "changeDataFeed", "appendOnly", "deletionVectors", "domainMetadata", "inCommitTimestamp", "invariants", "rowTracking", "timestampNtz", "variantType", "variantType-preview", "variantShredding-preview""#)), |
There was a problem hiding this comment.
this is a confusing error message. Can we either update it to be more clear about what's wrong, or if that's a bigger change, file a follow-up to clean it up?
There was a problem hiding this comment.
changed it to: "Found unsupported TableFeatures"
zachschuermann
approved these changes
Nov 4, 2025
|
Followup here: #1453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR enables writes to tables that have CDF enabled only if append only is also enabled.
Change Data Feed writes require cdc files to be written to the delta table for DML operations. However, delta-kernel-rs does not support writing cdc files. However, Change Data Feed appends do not require writing cdc files. Thus we enable CDF for tables where append only is enabled. Such tables are safe to write to because there will never be a DML operation that requires a cdc write.
How was this change tested?
Verify that table configuration fails on incorrect/invalid configurations.