feat: show "Failed" text on connection failure #26
+159
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `iceCandidatePoolSize` to prefetch ICE candidates before `setLocalDescription`. - Instantiate `RTCPeerConnection` sooner, don't wait for `getUserMedia()` to resolve. I have checked that this does indeed make us prepare the local offer faster by ~150ms. That is 300ms in total (per side). This commit also refactors the `CallsManager` by removing the `init()` method and moving its code into the constructor. This also helps us initialize it synchronously, which thus I have replaced `useEffect` with `useMemo` and moved the manager to inside the `App` component. Related: #10.
WofWca
commented
Sep 20, 2025
| window.calls.endCall(); | ||
| } | ||
|
|
||
| onFailed() { |
There was a problem hiding this comment.
Note that hypothetically this function can get called, for example, on a second startCall invokation, which would not be quite correct. After the connection has been first established, we should fail only if the connection itself fails terminally.
In such a case, we'd show the "failed" screen, but still keep sending the video to the remote party, without the user knowing it.
| }; | ||
|
|
||
| this.peerConnection.onconnectionstatechange = () => { | ||
| if (this.peerConnection.connectionState === "failed") { |
There was a problem hiding this comment.
Wait, it looks like this is not the terminal state? Based on my tests, the connection can still recover, without iceRestart().
| } | ||
|
|
||
| onFailed() { | ||
| console.log("onFailed, ending the call soon."); |
WofWca
force-pushed
the
wofwca/async-getIceServers
branch
2 times, most recently
from
09c0e24 to
d726836
Compare
|
this needs to be rebased now |
|
postponing this, closing for now to have a more clear view of what is really wanted and needing review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: