Skip to content

Conversation

WofWca
Copy link
Member

@WofWca WofWca commented Sep 24, 2025

image

Closes #28.

@WofWca WofWca force-pushed the wofwca/accept-call-prompt branch from db310dc to 42cf870 Compare September 25, 2025 13:54
@adbenitez
Copy link
Member

at first I wanted to have different pages/components for "incoming call offer" vs in-call vs "pre-videocall start" to reduce complexity, but the logic at App.tsx is already so interconnected and with the complex way of initializing the CallManager that I gave up, also they share components/buttons so maybe lets go for this way of all-in-one single component/page

@adbenitez
Copy link
Member

at first this looks a bit not so great to me, I just checked Telegram and this is how incoming videocalls look like:

image

and this is how an audio-only incoming call looks like:

image

I think it makes sense to separate the answer + reject from the other options

@WofWca
Copy link
Member Author

WofWca commented Sep 25, 2025

Yes, the design is inspired by Telegram.
I suggest to re-do design in follow-up MRs. What we have in this MR now is simple and good enough for a start IMO.

@adbenitez
Copy link
Member

adbenitez commented Sep 25, 2025

Yes, the design is inspired by Telegram. I suggest to re-do design in follow-up MRs. What we have in this MR now is simple and good enough for a start IMO.

sounds good, we can always iterate and improve in another PR, this PR is a draft, is something missing? (besides CI failing)

(EDIT: ah also the readme docs are missing)

To be in line with the command names.
Also `onIncomingCall` -> `acceptCall` is just better (IMO).
@WofWca
Copy link
Member Author

WofWca commented Sep 25, 2025

Also regarding the design, see how their desktop version looks:

image

@WofWca WofWca force-pushed the wofwca/accept-call-prompt branch from a06bbfe to 9d28835 Compare September 25, 2025 17:46
@WofWca WofWca marked this pull request as ready for review September 25, 2025 17:46
@WofWca
Copy link
Member Author

WofWca commented Sep 25, 2025

I have tested this on Desktop. Works great. See this branch https://github.com/deltachat/deltachat-desktop/tree/wofwca/calls-in-app-accept-user-prompt (you can replace the calls-webapp/index.html manually.

@WofWca WofWca force-pushed the wofwca/accept-call-prompt branch from 9d28835 to b9f5bc5 Compare September 25, 2025 18:30
Copy link
Member

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks a lot for pushing this forward! 🙏

@adbenitez adbenitez merged commit 63fd46e into main Sep 25, 2025
1 check passed
@adbenitez adbenitez deleted the wofwca/accept-call-prompt branch September 25, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"incoming call offer" screen needed
2 participants