-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add "Answer Call" button #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db310dc
to
42cf870
Compare
at first I wanted to have different pages/components for "incoming call offer" vs in-call vs "pre-videocall start" to reduce complexity, but the logic at App.tsx is already so interconnected and with the complex way of initializing the |
Yes, the design is inspired by Telegram. |
sounds good, we can always iterate and improve in another PR, this PR is a draft, is something missing? (besides CI failing) (EDIT: ah also the readme docs are missing) |
To be in line with the command names. Also `onIncomingCall` -> `acceptCall` is just better (IMO).
a06bbfe
to
9d28835
Compare
I have tested this on Desktop. Works great. See this branch https://github.com/deltachat/deltachat-desktop/tree/wofwca/calls-in-app-accept-user-prompt (you can replace the |
9d28835
to
b9f5bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks a lot for pushing this forward! 🙏
Closes #28.