Skip to content

fix: a11y: add aria-posinset for virtualized #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: a11y: add aria-posinset for virtualized #4660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

- keep the order of contacts when calling getContactsByIds #4651

### Fixed
- accessibility: fix screen readers announcing incorrect list sizes

<a id="1_54_0"></a>

## [1.54.0] - 2025-02-15
Expand Down
23 changes: 20 additions & 3 deletions packages/frontend/src/components/chat/ChatListItemRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,16 @@ export const ChatListItemRowChat = React.memo<{
const chatId = chatListIds[index]

return (
<li style={style}>
<li
style={style}
// TODO looks like screen-readers (at least NVDA) do not announce
// this "position" thing. Probably because the `<li>` itself
// is not focusable.
// Should we apply these attributes to the button?
// And get rid of the wrapper `<li>` entirely?
aria-posinset={index + 1}
aria-setsize={chatListIds.length}
>
<ChatListItem
isSelected={selectedChatId === chatId}
chatListItem={chatCache[chatId] || undefined}
Expand Down Expand Up @@ -98,7 +107,11 @@ export const ChatListItemRowContact = React.memo<{
}}
/>
) : (
<li style={style}>
<li
style={style}
aria-posinset={index + 1}
aria-setsize={contactIds.length}
>
<PlaceholderChatListItem />
</li>
)
Expand All @@ -116,7 +129,11 @@ export const ChatListItemRowMessage = React.memo<{
const accountId = selectedAccountId()

return (
<li style={style}>
<li
style={style}
aria-posinset={index + 1}
aria-setsize={messageResultIds.length}
>
{messageSearchResult ? (
<ChatListItemMessageResult
queryStr={queryStr || ''}
Expand Down
16 changes: 14 additions & 2 deletions packages/frontend/src/components/dialogs/AddMember/AddMemberInnerDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ function AddMemberInnerDialogRow({
queryStrIsValidEmail,
} = data

// `+1` for the "extra item" thing
const ariaSetsize = contactIds.length + 1

const renderAddContact = () => {
if (queryStrIsValidEmail) {
const pseudoContact: Type.Contact = {
Expand Down Expand Up @@ -358,7 +361,7 @@ function AddMemberInnerDialogRow({
)
} else {
return (
<li style={style}>
<li style={style} aria-posinset={index + 1} aria-setsize={ariaSetsize}>
<PseudoListItemAddContact
queryStr={queryStr}
queryStrIsEmail={false}
Expand All @@ -376,13 +379,22 @@ function AddMemberInnerDialogRow({
const contact = contactCache[contactIds[index]]
if (!contact) {
// Not loaded yet
return <li style={style}></li>
return (
<li
style={style}
aria-posinset={index + 1}
aria-setsize={ariaSetsize}
></li>
)
}

return (
<ContactListItem
tagName='li'
style={style}
// TODO does this get applied to the underlying element?
aria-posinset={index + 1}
aria-setsize={ariaSetsize}
contact={contact}
showCheckbox
checked={
Expand Down
Loading