Open
Conversation
Pipe Generation * Teach the pipe laying algorithm to prefer straight lines * Automatically rotate the pumpjacks * Connect the pumpjacks to form a MST with the trainstation instead of connection them all to the trainstation directly * Move pipe generation code into separate file Power Poles * Make sure all beacons and pumpjacks are covered by power poles * Try to minimize the number of power poles by heuristically solving the set problem of covering all consumers with power poles * Make sure that all power poles in the blueprint form a connected graph General * Add some timing log outputs to make the performance more observable
Owner
|
Awesome work! Will test out soon and merge. |
demipixel
reviewed
Jun 19, 2019
|
|
||
| let neighbors = []; | ||
| if (meta == 'start') { | ||
| for (let dir of [0, 1, 2, 3]) { |
Owner
There was a problem hiding this comment.
I think it may be worth adding an option to allow the user to use the original rotation of the pumpjack (I believe just pumpjack.direction/2 since some people may rather spend a bit more iron placing pipes over having to dig up every single pumpjack. Otherwise looks awesome :) Sorry for getting to this so late!
Contributor
Author
There was a problem hiding this comment.
Isn't this tool only really useful if you have construction robots and then you can just use a deconstruction planner?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, the PR got a bit bigger ^^. This does a lot of things:
Pipe Generation
connection them all to the trainstation directly
Power Poles
set problem of covering all consumers with power poles
General
If you merge this, you might want to mention in the tutorial, that the pumpjacks and single piece of track need be removed before the blueprint can be placed. Note that this is already the case if modules are added to the pumpjacks.
The more advanced pipe algorithm has runtimes of around 0.5sec on my machine for bigger outposts. That can probably be improved, but I didn't get to profiling yet.