Skip to content

Update DEMISTO_HTTP_HEADERS_REGEX_PATTERN to handle Cookie headers #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update DEMISTO_HTTP_HEADERS_REGEX_PATTERN to handle Cookie headers #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b6080
Update regex to handle Cookie headers
Apr 22, 2025
7e0152f
Added changelog entry
Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

[PyPI History](https://pypi.org/project/demisto-py/#history)

## 3.2.xx
* Updated custom request headers validation logic to handle "Cookie" headers.

## 3.2.14
* Added support for Python versions 3.11 and 3.12.

Expand Down
2 changes: 1 addition & 1 deletion demisto_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
__version__ = 'dev'


DEMISTO_HTTP_HEADERS_REGEX_PATTERN = r'^([\w-]+=[^=,\n]+)(,[\w-]+=[^=,\n]+)*$'
DEMISTO_HTTP_HEADERS_REGEX_PATTERN = r'^(Cookie=[^,\n]+|[\w-]+=[^=,\n]+)(,(Cookie=[^,\n]+|[\w-]+=[^=,\n]+))*$'


def configure(base_url=None, api_key=None, advanced_api_key=None, verify_ssl=None, proxy=None, username=None, password=None,
Expand Down
1 change: 1 addition & 0 deletions tests/mocks_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@ def test_configure_client_invalid_additional_headers_form_env_var(self, mocker:
"Content-type=123",
{'Content-type': '123'}
),

(
" ",
{}
Expand Down