perf: key gen cache by emit configuration #30791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deno internally uses a bunch of different emit configurations, particularly regarding source maps. The gen cache was layed out to support only one emit for a given source at a time. If two systems were trying to transpile the same source file in different ways, for example `deno run` and `@deno/loader`, the gen output for that file would keep thrashing, making everything slower. This commit fixes this by including the `transpile_and_emit_options_hash` in the gen folder name. Additionally, we move from `$DENO_DIR/gen` to `$DENO_DIR/gen_v2`.
lucacasonato
commented
Sep 22, 2025
|
Maybe we could continue to use the existing root folder for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno internally uses a bunch of different emit configurations, particularly regarding source maps.
The gen cache was layed out to support only one emit for a given source at a time. If two systems were trying to transpile the same source file in different ways, for example
deno runand@deno/loader, the gen output for that file would keep thrashing, making everything slower.This commit fixes this by including the
transpile_and_emit_options_hashin the gen folder name. Additionally, we move from$DENO_DIR/gento$DENO_DIR/gen_v2.