WIP: ALEFindReferences: add -fzf flag to show output in fzf #5018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2025
…ntents option to configure default behaviour
- add support for opening in splits, tabs and for adding matches quickfix - add support for -relative - add fzf preview `--highlight-line` option - cleanup fzf options
w0rp
reviewed
Aug 13, 2025
There was a problem hiding this comment.
Seems like a decent idea to me for fzf users. You could move the fzf specific code to an autoload/ale/fzf.vim script so it's only loaded on demand. You could edit the HandleLSPResponse function back to how it was without the early return as it was fine how it was and we don't need such a big diff.
| \) | ||
| endfor | ||
| function! ale#references#ShowInFzf(item_list, options) abort | ||
| let name = "LSP References" |
There was a problem hiding this comment.
Use the l: variable prefix for local variables to be consistent with the rest of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (WIP) adds
:ALEFindReferences -fzfto list/matches found by the LSP Server using fzf and fzf.vim.This is a very rough draft, but this is what's working:
What's not done yet:
Here's what this looks like so far:
asciicast
old asciicast
Related: #2252, #3321, #5001
cc @w0rp would love some feedback