Skip to content

Conversation

rymdbar
Copy link
Contributor

@rymdbar rymdbar commented Aug 31, 2025

Update to use mentioned function to find both .git/ directories and .git work-tree files.

Update to use mentioned function to find both .git/ directories and .git
worktree files.
@rymdbar
Copy link
Contributor Author

rymdbar commented Aug 31, 2025

Tests are failing due to supposedly:

./ale_linters/perl/languageserver.vim:20 Blank line required after let

However, there is a blank line after let (or rather before if). The documentation does not appear to mention anything about any non-existing required empty line under these circumstances, nor does vint indicate it. Is the test-suite misidentifying this as a false positive? is the documentation incomplete? or am I reading something incorrectly?

@hsanson
Copy link
Contributor

hsanson commented Sep 6, 2025

@rymdbar this error is from the ale_custom_linting_rules linter. I recommend you enable it in your configuration so vim/nvim warns you about these issues:

linters = {
   vim = { "vint", "ale_custom_linting_rules" },
}

The error is misleading since it says "after" but I can get the warning to dissapear by adding a blank line before that line.

@rymdbar
Copy link
Contributor Author

rymdbar commented Sep 19, 2025

@rymdbar this error is from the ale_custom_linting_rules linter.

Yes? As already covered in previous comment.

The error is misleading since it says "after" but I can get the warning to dissapear by adding a blank line before that line.

So you're suggestion, @hsanson, is that we unblock this PR by updating the documentation? Please feel free to suggest how the new wording should be.

I'm more getting the hunch this is caused by a false positive. If it indeed is correct, what is the motivation for requiring an empty line at this position?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants