Send JSON-RPC error responses for unknown request methods #5044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Language Server Protocol requires that all requests receive responses. Previously, ALE would silently ignore unknown JSON-RPC requests from language servers (like workspace/configuration), violating the LSP specification. Solution: - Modified the central message handler in ale#lsp#HandleMessage to track whether any handler processed each message - Added handler return values: handlers now return v:true when they process server-initiated requests/notifications - Only 2 handlers needed modification since most handle client request responses: * ale#lsp_linter#HandleLSPResponse (textDocument/publishDiagnostics, etc.) * ale#codefix#HandleLSPResponse (workspace/applyEdit) - Unknown requests now receive standard JSON-RPC error responses with code -32601 (Method Not Found) This ensures ALE is compliant with the LSP specification requirement that "Every processed request must send a response back to the sender." 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The Language Server Protocol requires that all requests receive responses. Previously, ALE would silently ignore unknown JSON-RPC requests from language servers (like workspace/configuration), violating the LSP specification. Solution: - Modified the central message handler in ale#lsp#HandleMessage to track whether any handler processed each message - Added handler return values: handlers now return v:true when they process server-initiated requests/notifications - Only 2 handlers needed modification since most handle client request responses: * ale#lsp_linter#HandleLSPResponse (textDocument/publishDiagnostics, etc.) * ale#codefix#HandleLSPResponse (workspace/applyEdit) - Unknown requests now receive standard JSON-RPC error responses with code -32601 (Method Not Found) This ensures ALE is compliant with the LSP specification requirement that "Every processed request must send a response back to the sender." 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Language Server Protocol requires that all requests receive responses. Previously, ALE would silently ignore unknown JSON-RPC requests from language servers (like workspace/configuration), violating the LSP specification.
Solution:
This ensures ALE is compliant with the LSP specification requirement that "Every processed request must send a response back to the sender."
🤖 Generated with Claude Code
Fixes #4610
I have not added vader test, due to insufficient AI training data. Yet I think this pull request is good enough for an inspiration.