feat: Fix link rewriting for localhost:PORT #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using stac-auth-proxy with
ROOT_PATHset, links containinglocalhost:PORT(e.g.,localhost:8080) were not rewritten. The proxy only matched exact netloc strings, solocalhost:8080didn't match localhost, causing 404s when clients followed these links. This is probably a common need for runningstac-fastapibehind a load balancer.This PR proposes:
_extract_hostname()to extract hostnames ignoring ports_hostnames_match()to compare hostnames case-insensitively, ignoring ports_update_link()to compare hostnames instead of exact netloc matches