-
Notifications
You must be signed in to change notification settings - Fork 67
fix: create links in entrypoint for files under /home/tooling/.config #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Files under /home/tooling/.config are not stowed in the entrypoint because it is in the .stow-local-ignore file. Stow ignores everything in the .config folder because the /home/user/.config folder should be created in the entrypoint in order to have proper user permissions required for Podman 5.x. Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
Pull Request images published ✨ |
Hello @svor could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested using instructions form the description.
@dkwon17 could you please explain how or where .copy-files
file is used
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for the review, Right now Che doesn't depend on this feature anywhere, it's a feature that is very helpful for moving |
@dkwon17 Thank you for the explanation |
…devfile#226) * fix: create links in entrypoint for files under /home/tooling/.config Files under /home/tooling/.config are not stowed in the entrypoint because it is in the .stow-local-ignore file. Stow ignores everything in the .config folder because the /home/user/.config folder should be created in the entrypoint in order to have proper user permissions required for Podman 5.x. Signed-off-by: David Kwon <[email protected]>
Files under
/home/tooling/.config
are not stowed in the entrypoint because it is in the.stow-local-ignore
file. Stow ignores everything in the.config
folder because the/home/user/.config
folder should be created in the entrypoint in order to have proper user permissions required for Podman 5.x.This PR fixes https://issues.redhat.com/browse/CRW-8932
See #197
How I tested this PR:
quay.io/dkwon17/base-developer-image:persist-config-files
.Dockerfile
test.conf
quay.io/dkwon17/test:persist-config-files
podman run {image}
) and exec into it. Verify that there are links from files under/home/tooling/.config
to/home/user/.config
: