fix: Prevent multiple versions of axios from being bundled in consumer projects #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
axios
library from being bundled in consumer projects.At the moment build of the
che-code
fails with the errors: eclipse-che/che#23083 (comment)My understanding is:
che-code
project passesaxios
instance to thedevWorkspaceGenerator
che-code
anddevWorkspaceGenerator
haveaxios
as a dependencytypescript
"thinks" that there are two different instances of theaxios
and throws errors Align che-code typescript version with the upstream eclipse-che/che#23083 (comment)typescript
version was updated - so more strict checks where appliedMy propose is - moving
axios
fromdependencies
to:peerDependencies
section: to declareaxios
as a required dependency provided by theconsuming
project (che-code
project passesaxios
instance to thedevWorkspaceGenerator
)devDependencies
: to allow internal use and local development/testing of this packageWhat issues does this PR fix or reference?
eclipse-che/che#23083 (comment)
Is it tested? How?
For testing:
devWorkspaceGenerator
as afile
dependency directly to theche-code
, please see hereche-code/devWorkspaceGenerator
, please see hereche-code
please see herePlease let me know if there is another way for testing - will do it!