feat: refactor date picker components and remove deprecated code #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new DateTimePicker component to replace the existing SingleDatePicker and DayPickerRangeController. - Updated DeploymentMetrics and CustomLogsModal to utilize the new DateTimePicker for date selection. - Removed unused styles and components related to the old date picker implementation. - Added utility functions for generating date range options for the new date picker. - Cleaned up imports and adjusted type definitions to accommodate the new date handling logic.
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
github-actions
bot
added
the
PR:Issue-verification-failed
AbhishekA1509
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
github-actions
bot
added
PR:Ready-to-Review
…, GraphModal, and DeploymentMetrics components
AbhishekA1509
commented
Dec 1, 2025
| startDate: startStr, | ||
| endDate: 'now', | ||
| }) | ||
| const str = getCalendarValue(startStr, 'now') |
Member
Author
There was a problem hiding this comment.
Need to check if now-5m and now - 5m are same?
…ency and readability
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the way expiration dates are handled for API tokens, moving from using
momentand custom types to a more standardized approach withdayjsand shared types from the common library. The changes improve type safety, maintainability, and UI consistency for selecting and displaying expiration dates.Expiration date handling and UI improvements:
momentand custom date types withdayjsand standardized types (ExpirationDateSelectOptionType) throughout API token components, includingCreateAPIToken,EditAPIToken, andRegenerateModal. [1] [2] [3] [4] [5] [6] [7]DateTimePickercomponent and improved option handling with typed values, enhancing the UI and code reliability. [1] [2] [3]DATE_TIME_FORMATSfrom the common library, ensuring consistent display of dates. [1] [2] [3] [4] [5]Dependency cleanup:
react-datesand its type definitions frompackage.json, as date handling is now done via shared components and libraries. [1] [2]Fixes https://github.com/devtron-labs/sprint-tasks/issues/2714
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: