Skip to content

chore: updated logic to explicitly set value for empty env default value #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: updated logic to explicitly set value for empty env default value #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions common-lib/fetchAllEnv/fetchAllEnv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ type CategoryField struct {
}

const (
categoryCommentStructPrefix = "CATEGORY="
defaultCategory = "DEVTRON"
deprecatedDefaultValue = "false"
categoryCommentStructPrefix = "CATEGORY="
defaultCategory = "DEVTRON"
deprecatedDefaultValue = "false"
envDefaultEmptyDataPlaceholder = "NA"

envFieldTypeTag = "env"
envDefaultFieldTypeTag = "envDefault"
Expand Down Expand Up @@ -138,9 +139,12 @@ func processGoFile(filePath string, categoryFieldsMap map[string][]EnvField, uni

func getEnvKeyAndValue(field *ast.Field) EnvField {
tag := reflect.StructTag(strings.Trim(field.Tag.Value, "`")) // remove surrounding backticks

envValueTag, envValueSet := tag.Lookup(envDefaultFieldTypeTag)
if envValueSet && len(envValueTag) == 0 { //tag explicitly set up but empty value
envValueTag = envDefaultEmptyDataPlaceholder
Copy link
Contributor

@nishant-d nishant-d Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be just keeping it empty instead of "NA"?

}
envKey := addReadmeTableDelimiterEscapeChar(tag.Get(envFieldTypeTag))
envValue := addReadmeTableDelimiterEscapeChar(tag.Get(envDefaultFieldTypeTag))
envValue := addReadmeTableDelimiterEscapeChar(envValueTag)
envDescription := addReadmeTableDelimiterEscapeChar(tag.Get(envDescriptionFieldTypeTag))
envPossibleValues := addReadmeTableDelimiterEscapeChar(tag.Get(envPossibleValuesFieldTypeTag))
envDeprecated := addReadmeTableDelimiterEscapeChar(tag.Get(envDeprecatedFieldTypeTag))
Expand Down
Loading