Skip to content

fix: unify unit formatting and conversion for CPU and memory in cluster resources #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

fix: unify unit formatting and conversion for CPU and memory in cluster resources #6765

wants to merge 23 commits into from

Conversation

SATYAsasini
Copy link
Contributor

@SATYAsasini SATYAsasini commented Jul 28, 2025 •
edited by bito-code-review bot
Loading

Description

Fixes #6764

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Summary by Bito

This PR standardizes unit formatting and conversion logic for CPU and memory resources, implementing distinct handling for CPU (cores/milli) and memory (Gi/Mi/Ki). It enhances rounding precision, improves documentation, and resolves formatting inconsistencies for more accurate resource reporting.

prkhrkat and others added 20 commits July 17, 2025 16:01
@prkhrkat
ephemeral error fix
07f7770
@prkhrkat
ephemeral error fix (#6737)
3f7053c
@iamayushm
panic fix
a031cb4
@iamayushm
Merge pull request #6738 from devtron-labs/panic-fix-post-trigger
da845f2 
chore: post trigger
@prkhrkat
NotificationRule removed
1084153
@prkhrkat
Merge branch 'release-candidate-v0.40.0' into rc40-fixes
3b61f5f
@vikramdevtron
Merge pull request #6739 from devtron-labs/rc40-fixes
6bb7bed 
misc: notification table fix
@vikramdevtron
Merge pull request #6740 from devtron-labs/release-candidate-v0.40.0
74a4c04 
sync: Release candidate v0.40.0
@vikramdevtron
vendor update
0d3e575
@vikramdevtron
Merge pull request #6741 from devtron-labs/vendor-update-release-40
3310508 
sync: vendor update
@akshatsinha007
misc: Added Github Actions for linting and building api specs (#6720)
49ad5b9 
* Added action to check for linting errors in openapi.yaml

* Create build-docs.yaml

* added read-only permission in api-linter

* updated action to add permission
@kamal-devtron
misc: open api spec addition (#6750)
dad6d30 
* added version yml

* changes in openapi.yaml
@akshatsinha007
Updated build-docs.yaml (#6752)
9c95a07 
switch the approach from rebasing to creating a temp folder and copying the file
@badal773
misc: fixing swagger openapi.yaml (#6751)
6503b20 
* resolved application.yaml

* resolved application.yaml

* resolved applisting.yaml

* resolved charts.yaml helm-apps list

* resolved jobs.yaml jobs list

* removed unrequired server

* renamed the x-displayName

* resolved app-labels.yaml

* resolved merge-conflict

* resolved merge-conflict - 02

* added Get Deployment History (ENT) spec
@badal773
misc: adding codeowner for swagger api spec (#6754)
4324e77 
* adding codeowner for swagger api spec

* adding codeowner for swagger api spec
@kamal-devtron
gitops validation spec added (#6755)
f3038cf
@pawan-59
misc: Update openapi spec (#6758)
b15f69a 
* Updated openapi-spec with notificats api

* updated openapi-spec to add historical-get-api-change
@pawan-59
updated the title of openapi specs (#6759)
e177cb3
@prkhrkat
removed timeout notification (#6760)
bbd8a5f
@prkhrkat
misc: Timeout main notification (#6761)
680616b 
* removed timeout notification

* removed timeout notification
@bito-code-review
Copy link

bito-code-review bot commented Jul 28, 2025 •
edited
Loading

Code Review Agent Run #42930a

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 88e3a5c..88d9993
    • pkg/k8s/capacity/k8sCapacityService.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@bito-code-review
Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Bug Fix - CPU and Memory Unit Conversion Bug Fix

- k8sCapacityService.go - Refined conversion logic and rounding for CPU and memory, adding specialized handling and detailed comments to better distinguish resource formatting.

@bito-code-review
Copy link

Bito Banner

Bito's AI Code Review trial is almost over
Your free trial of Bito's AI Code Reviews was setup by [email protected] and is nearly over. Let them know if you'd like to continue getting complete reviews.

Sign in to upgrade

About Bito
Merge PRs 89% faster, with 34% fewer regressions, and 87% of relevant PR feedback provided by Bito's AI Code Reviews. Trusted by 100,000+ developers and 1,000+ engineering teams.

@bito-code-review
Copy link

bito-code-review bot commented Jul 28, 2025 •
edited
Loading

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

@bito-code-review
Copy link

Bito Banner

Bito's AI Code Review trial is almost over
Your free trial of Bito's AI Code Reviews was setup by [email protected] and is nearly over. Let them know if you'd like to continue getting complete reviews.

Sign in to upgrade

About Bito
Merge PRs 89% faster, with 34% fewer regressions, and 87% of relevant PR feedback provided by Bito's AI Code Reviews. Trusted by 100,000+ developers and 1,000+ engineering teams.

@SATYAsasini SATYAsasini force-pushed the fix-clusterDetailResourceCapacity branch 2 times, most recently from 3217e46 to 8e43026 Compare July 28, 2025 09:27
@bito-code-review
Copy link

bito-code-review bot commented Jul 28, 2025 •
edited
Loading

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

@bito-code-review
Copy link

Bito Banner

Bito's AI Code Review trial is almost over
Your free trial of Bito's AI Code Reviews was setup by [email protected] and is nearly over. Let them know if you'd like to continue getting complete reviews.

Sign in to upgrade

About Bito
Merge PRs 89% faster, with 34% fewer regressions, and 87% of relevant PR feedback provided by Bito's AI Code Reviews. Trusted by 100,000+ developers and 1,000+ engineering teams.

@SATYAsasini SATYAsasini force-pushed the fix-clusterDetailResourceCapacity branch from d636862 to 8e43026 Compare July 28, 2025 09:34
@SATYAsasini SATYAsasini deleted the fix-clusterDetailResourceCapacity branch July 28, 2025 09:35
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bito-code-review
Copy link

bito-code-review bot commented Jul 28, 2025 •
edited
Loading

Bito Review Skipped - Source Branch Not Found

Bito didn’t review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

@bito-code-review
Copy link

Bito Banner

Bito's AI Code Review trial is almost over
Your free trial of Bito's AI Code Reviews was setup by [email protected] and is nearly over. Let them know if you'd like to continue getting complete reviews.

Sign in to upgrade

About Bito
Merge PRs 89% faster, with 34% fewer regressions, and 87% of relevant PR feedback provided by Bito's AI Code Reviews. Trusted by 100,000+ developers and 1,000+ engineering teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

@pawan-mehta-dt pawan-mehta-dt Awaiting requested review from pawan-mehta-dt pawan-mehta-dt is a code owner

@tayalrishabh96 tayalrishabh96 Awaiting requested review from tayalrishabh96 tayalrishabh96 is a code owner

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@SATYAsasini @prkhrkat @iamayushm @vikramdevtron @akshatsinha007 @kamal-devtron @badal773 @pawan-59