Skip to content

Conversation

SATYAsasini
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@SATYAsasini SATYAsasini changed the title Fix api responses fix: api responses Aug 21, 2025
Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

Copy link

gitguardian bot commented Aug 21, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret e20bc6a tests/api-spec-validation/Makefile View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@prkhrkat prkhrkat merged commit 0b64f4e into feat-api-spec-validator Aug 25, 2025
3 checks passed
@prkhrkat prkhrkat deleted the fix-api-responses branch August 25, 2025 07:15
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

prkhrkat added a commit that referenced this pull request Aug 25, 2025
)

* corrected api specs

* specs enhance

* Merge pull request #6771 from devtron-labs/fix-cron-job-suspend

fix: cron job suspend

* fix: update default sequence for bulk edit config table and correct README link

* corrected specs

* corrected specs

* Improve CI status fetching logic in `CiHandlerImpl` to handle linked pipelines, add duplicate removal utility, and enhance logging and fallback mechanisms.

* Refactor `CiHandlerImpl` to modularize and streamline CI pipeline status fetching, extracting common logic into reusable functions and improving linked pipeline handling.

* Remove redundant comments in `CiHandler.go` to enhance code clarity and maintain consistency with refactored CI status handling logic.

* Clean up redundant comments in `preparePipelineStatusLookup` to enhance readability and align with refactored CI pipeline handling logic.

* Remove unused `mapWorkflowsToLinkedPipelines` function from `CiHandler.go` to enhance code clarity and eliminate dead code.

* Extract `RemoveDuplicateInts` utility to `CiCdUtil.go` for reusability and replace the inlined method in `CiHandler.go`.

* vendor for spec-validator

* spec-fixes as per cursor when ran on results file

* spec-fixes manually for /orchestrator path

* script fix to run against server

* naming changed from devtron-lab

duplicated removed

ap spec correction

* removed extra code

* wip: adding cluster status

* fix cluster status

* Enhance CI status fetching in `CiHandlerImpl` to handle linked pipelines. Add linked pipeline mapping and workflow statuses, refactor status population logic, and introduce reusable adapter methods for linked CI workflows.

* framework.go update

* api-spec fix

api-spec fix

api-spec fix

api-spec fix

API Error wrapper

API Error wrapper

specs fixes

* spec fix

* script fix

* Update workflow status table scripts to latest version.

* Update `authenticator` and `common-lib` dependencies to latest versions.

* added sql ent files (#6780)

* devops specs included

* script fix

* script fix

* migration number chnage (#6783)

* feat: add resource recommendation APIs and update openapi.yaml

* feat: add Resource Recommendation to openapi.yaml

* specs fix

* redocly script to generate html

* refact

* refact

* refact

* doc: api spec merger

* chore: test commit

* misc: script name rectified in action file

* misc: testing change in /spec

* misc: test commit

* misc: test commit

* refact

* refact

* refact

* refact

* feat: action fix and resource recommender specs

* fix: action fixes

* chore: test trigger commit

* chore: test run commit

* chore: test commit

* chore: test commit

* feat: git push job in action file

* feat: git push job in action file

* chore: test commit

* chore: test commit

* chore: test commit

* chore: test commit

* fix panic

* chore: test commit

* chore: test commit

* chore: test commit

* fix: script misc chore fixes and trigger commit

* fix: script fixes

* fix: script fixes

* fix: script fixes

* fix: script fixes

* fix: script fixes

* fix: script fixes

* fix: script fixes

* create API token validation

* misc: added support for cronjob annotations and probes (#6787)

* added support for cronjob annotations and probes

* support for older charts

* reconfiguring semverCompare

* removed restartPolicy from cronjob-config

* added support for external-secrets.io/v1

* added default values for eso

* older compatibility

* rectify the semverCompare

* added support for jobLabels and jobAnnotations

* refact

* refact

* security policy specs fixed

* refact

* refact

* refact

* refact

* refact

* refact

* ent separation

* ent separation

* feat: automate API specs workflow and documentation (#6786)

* feat: api spec hosting mechanism

* fix: trigger condition update on wf file

* fix: remove old wf

* refact in specs

* generate-api-docs.sh fix

---------

Co-authored-by: prakhar katiyar <[email protected]>
Co-authored-by: prakhar katiyar <[email protected]>

* driftSpec.yaml added

* fix: API token generation api responses refactoring (#6788)

* fix: API token generation api responses refactoring

* fix: register custom validation against tag for api token name validations

* fix: register custom validation against tag for api token name validations

* Revert "fix: register custom validation against tag for api token name validations"

This reverts commit 7593c27.

* fix: remove `required` validation from Description and expiryAtInMs

* fix: adding resource conflict api response in WriteJsonResp utility

* fix: path params int validation updated to whole numbers only

* fix: handled resource not found response for update and delete api, token

* path corrected

* cmscs added

* corrected specs

* fix: api responses (#6789)

* fix: API token generation api responses refactoring

* fix: register custom validation against tag for api token name validations

* fix: register custom validation against tag for api token name validations

* Revert "fix: register custom validation against tag for api token name validations"

This reverts commit 7593c27.

* fix: remove `required` validation from Description and expiryAtInMs

* fix: adding resource conflict api response in WriteJsonResp utility

* fix: path params int validation updated to whole numbers only

* fix: handled resource not found response for update and delete api, token

* fix: validation for SSO config name field

* fix: enhanced query param validation for commit metadata for pipeline material

* fix: disable updating clsutername and api name in update clsuter api

* fix: enhanced api response in query param validation failure reeors in ge default deployment template

* fix: disable modifying cluster nae and env name in update env api

* fix: resolving review comments

* fix: resolving review comments

---------

Co-authored-by: iamayushm <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: Prakash Kumar <[email protected]>
Co-authored-by: ayushmaheshwari <[email protected]>
Co-authored-by: Vikram <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: SATYAsasini <[email protected]>
Co-authored-by: Badal Kumar <[email protected]>
Co-authored-by: satya_prakash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants