Feat api spec validator #6803
Closed
Feat api spec validator #6803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # specs/common/delete-options.yaml
duplicated removed ap spec correction
api-spec fix api-spec fix api-spec fix API Error wrapper API Error wrapper specs fixes
* fix: API token generation api responses refactoring * fix: register custom validation against tag for api token name validations * fix: register custom validation against tag for api token name validations * Revert "fix: register custom validation against tag for api token name validations" This reverts commit 7593c27. * fix: remove `required` validation from Description and expiryAtInMs * fix: adding resource conflict api response in WriteJsonResp utility * fix: path params int validation updated to whole numbers only * fix: handled resource not found response for update and delete api, token
…n ge default deployment template
* fix: API token generation api responses refactoring * fix: register custom validation against tag for api token name validations * fix: register custom validation against tag for api token name validations * Revert "fix: register custom validation against tag for api token name validations" This reverts commit 7593c27. * fix: remove `required` validation from Description and expiryAtInMs * fix: adding resource conflict api response in WriteJsonResp utility * fix: path params int validation updated to whole numbers only * fix: handled resource not found response for update and delete api, token * fix: validation for SSO config name field * fix: enhanced query param validation for commit metadata for pipeline material * fix: disable updating clsutername and api name in update clsuter api * fix: enhanced api response in query param validation failure reeors in ge default deployment template * fix: disable modifying cluster nae and env name in update env api * fix: resolving review comments * fix: resolving review comments
fix: enhacned api responses and error mesages
prkhrkat
requested review from
vikramdevtron,
prakarsh-dt and
vivek-devtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 19465121 | Triggered | Generic High Entropy Secret | 15b2a4f | scripts/sql/34304100_bulk_edit_config.up.sql | View secret |
| 20477209 | Triggered | Generic High Entropy Secret | 40bb962 | tests/api-spec-validation/Makefile | View secret |
| 19602448 | Triggered | Generic High Entropy Secret | 4338a20 | tests/api-spec-validation/Makefile | View secret |
| 19601641 | Triggered | AWS IAM Keys | 67387e6 | tests/api-spec-validation/reports/live-server-validation-report.md | View secret |
| 19578172 | Triggered | Generic High Entropy Secret | b35c605 | tests/api-spec-validation/Makefile | View secret |
| 19601642 | Triggered | GitHub Fine Grained Personal Access Token | 67387e6 | tests/api-spec-validation/reports/live-server-validation-report.md | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito
This pull request enhances error handling across API endpoints by providing clearer error messages for invalid app IDs and missing parameters. It also improves logging for better request validation, aiming to increase the robustness of the API.