Skip to content

build: sirv dev dependency#324

Merged
peterpeterparker merged 1 commit intomainfrom
svelte-build-sirv-cli
Jan 4, 2022
Merged

build: sirv dev dependency#324
peterpeterparker merged 1 commit intomainfrom
svelte-build-sirv-cli

Conversation

@peterpeterparker
Copy link
Member

Motivation

The local test server was referenced as a bundle dependency.

Changes

  • Moves sirv from a dependency to a devDependency
  • Removes start params --no-clear which does not seem to be supported according README

@peterpeterparker peterpeterparker added the good first issue Good for newcomers label Jan 3, 2022
Copy link
Contributor

@bitdivine bitdivine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peterpeterparker
Copy link
Member Author

My pleasure.

Side notes: the svelte discussion / pr about why it is listed as a dependency per default in the svelte kit (which does not apply here).

Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterpeterparker peterpeterparker merged commit 3d86b78 into main Jan 4, 2022
@peterpeterparker peterpeterparker deleted the svelte-build-sirv-cli branch January 4, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants