Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/repo_policies/BOT_APPROVED_FILES
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ declarations/*/*/*.did
dfx.json
frontend/package-lock.json
frontend/src/tests/workflows/Launchpad/sns-agg-page-*.json
rs/proposals/src/canisters/*/api.rs
rs/sns_aggregator/src/types/*.rs
rust-toolchain.toml
23 changes: 0 additions & 23 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,6 @@ jobs:
run: scripts/install-didc
- name: Check didc
run: command -v didc
- name: Run the ic_commit code generator for proposals
run: |
./scripts/update_ic_commit --crate proposals --ic_commit "$(jq -re .defaults.build.config.IC_COMMIT_FOR_PROPOSALS config.json)"
./scripts/proposals/did2rs
- name: Run the ic_commit code generator for sns_aggregator
run: |
./scripts/update_ic_commit --crate sns_aggregator --ic_commit "$(jq -re .defaults.build.config.IC_COMMIT_FOR_SNS_AGGREGATOR config.json)"
Expand Down Expand Up @@ -207,25 +203,6 @@ jobs:
run: |
set +x
scripts/nns-dapp/migration-test.on-exit.test
dfx-nns-proposal-args-works:
# TODO: Re-enable (add it in line 338) once fixed, should it depend on mainnet?
if: false
name: Can get NNS proposal args
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v6
- name: Install didc
run: scripts/install-didc
- name: Install cargo binstall
uses: ./.github/actions/install_binstall
- name: Install idl2json
run: cargo binstall --no-confirm "idl2json_cli@$(jq -r .defaults.build.config.IDL2JSON_VERSION config.json)" && idl2json --version
- name: Install sponge
run: sudo apt-get update -yy && sudo apt-get install -yy moreutils && command -v sponge
- name: Install dfx
uses: dfinity/setup-dfx@main
- name: Test getting proposal args
run: scripts/dfx-nns-proposal-args.test
minor-version-bump-works:
runs-on: ubuntu-22.04
steps:
Expand Down
118 changes: 0 additions & 118 deletions .github/workflows/update-proposals.yml

This file was deleted.

41 changes: 0 additions & 41 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[workspace]
members = [
"rs/backend",
"rs/proposals",
"rs/sns_aggregator"
]
resolver = "2"
Expand All @@ -16,19 +15,15 @@ ic-management-canister-types = "0.4.1"

cycles-minting-canister = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
dfn_candid = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
dfn_core = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
dfn_protobuf = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-base-types = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-crypto-sha2 = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-ledger-core = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-nervous-system-common = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-nervous-system-root = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-nns-common = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-nns-constants = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-nns-governance = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-protobuf = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
ic-sns-swap = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
registry-canister = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
icp-ledger = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
icrc-ledger-types = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
on_wire = { git = "https://github.com/dfinity/ic", rev = "release-2025-08-14_03-27-base" }
Expand Down
6 changes: 2 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
# Check the memory available to docker.
# - If run on Linux, the RAM will be the same as the host machine.
# - If run on Mac, Docker will be spinning up a Linux virtual machine and then running docker inside that; the user can change the memory available to the virtual machine.
FROM --platform=linux/amd64 ubuntu:22.04 as check-environment

Check warning on line 11 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 11 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/
SHELL ["bash", "-c"]
ENV TZ=UTC
RUN awk -v gigs=4 '/^MemTotal:/{if ($2 < (gigs*1024 * 1024)){ printf "Insufficient RAM. Please provide Docker with at least %dGB of RAM\n", gigs; exit 1 }}' /proc/meminfo

# Operating system with basic tools
FROM --platform=linux/amd64 ubuntu:22.04 as base

Check warning on line 17 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 17 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/
SHELL ["bash", "-c"]
ENV TZ=UTC
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone && \
Expand All @@ -28,7 +28,7 @@
# Note: This can be done in the builder but is slow because unrelated changes to dfx.json can cause a rebuild.
#
# Note: Here we play a bit with the idea of storing config in files, one file per parameter.
FROM base as tool_versions

Check warning on line 31 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
SHELL ["bash", "-c"]
RUN mkdir -p config
COPY dfx.json dfx.json
Expand All @@ -41,7 +41,7 @@
RUN jq -r '.defaults.build.config.BINSTALL_VERSION' config.json > config/binstall_version

# This is the "builder", i.e. the base image used later to build the final code.
FROM base as builder

Check warning on line 44 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
SHELL ["bash", "-c"]
# Get tool versions
COPY --from=tool_versions /config/*_version config/
Expand Down Expand Up @@ -69,9 +69,8 @@
COPY Cargo.lock .
COPY Cargo.toml .
COPY rs/backend/Cargo.toml rs/backend/Cargo.toml
COPY rs/proposals/Cargo.toml rs/proposals/Cargo.toml
COPY rs/sns_aggregator/Cargo.toml rs/sns_aggregator/Cargo.toml
RUN mkdir -p rs/backend/src/bin rs/proposals/src rs/sns_aggregator/src && touch rs/backend/src/lib.rs rs/proposals/src/lib.rs rs/sns_aggregator/src/lib.rs && echo 'fn main(){}' | tee rs/backend/src/main.rs > rs/backend/src/bin/nns-dapp-check-args.rs && cargo build --target wasm32-unknown-unknown --release --package nns-dapp && rm -f target/wasm32-unknown-unknown/release/*wasm
RUN mkdir -p rs/backend/src/bin rs/sns_aggregator/src && touch rs/backend/src/lib.rs rs/sns_aggregator/src/lib.rs && echo 'fn main(){}' | tee rs/backend/src/main.rs > rs/backend/src/bin/nns-dapp-check-args.rs && cargo build --target wasm32-unknown-unknown --release --package nns-dapp && rm -f target/wasm32-unknown-unknown/release/*wasm
# Install dfx
WORKDIR /
# dfx is installed in `$HOME/.local/share/dfx/bin` but we can't reference `$HOME` here so we hardcode `/root`.
Expand All @@ -93,7 +92,7 @@
COPY scripts/network-config /build/scripts/network-config
COPY scripts/dfx-canister-url /build/scripts/dfx-canister-url
COPY scripts/clap.bash /build/scripts/clap.bash
COPY .df[x]/ /build/.dfx

Check warning on line 95 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

Attempting to Copy file that is excluded by .dockerignore

CopyIgnoredFile: Attempting to Copy file ".df[x]" that is excluded by .dockerignore More info: https://docs.docker.com/go/dockerfile/rule/copy-ignored-file/
WORKDIR /build
ARG DFX_NETWORK=mainnet
RUN mkdir -p frontend
Expand Down Expand Up @@ -134,7 +133,6 @@
FROM builder AS build_nnsdapp
SHELL ["bash", "-c"]
COPY ./rs/backend /build/rs/backend
COPY ./rs/proposals /build/rs/proposals
COPY ./scripts/nns-dapp/test-exports /build/scripts/nns-dapp/test-exports
COPY ./scripts/clap.bash /build/scripts/clap.bash
COPY ./build-backend.sh /build/
Expand All @@ -156,7 +154,7 @@
# So we update the timestamps of the root code files.
# Old canisters use src/main.rs, new ones use src/lib.rs. We update the timestamps on all that exist.
# We don't wish to update the code from main.rs to lib.rs and then have builds break.
RUN touch --no-create rs/backend/src/main.rs rs/backend/src/lib.rs rs/proposals/src/lib.rs
RUN touch --no-create rs/backend/src/main.rs rs/backend/src/lib.rs
RUN ./build-backend.sh
COPY ./scripts/dfx-wasm-metadata-add /build/scripts/dfx-wasm-metadata-add
ARG COMMIT
Expand Down Expand Up @@ -189,7 +187,7 @@
RUN for wasm in sns_aggregator.wasm.gz sns_aggregator_dev.wasm.gz ; do scripts/dfx-wasm-metadata-add --commit "$COMMIT" --canister_name sns_aggregator --verbose --wasm "$wasm" ; done

# Title: Image used to extract the final outputs from previous steps.
FROM scratch AS scratch

Check warning on line 190 in Dockerfile

View workflow job for this annotation

GitHub Actions / Same wasms for mainnet and local

Reserved words should not be used as stage names

ReservedStageName: Stage name should not use the same name as reserved stage "scratch" More info: https://docs.docker.com/go/dockerfile/rule/reserved-stage-name/
COPY --from=configurator /build/deployment-config.json /
COPY --from=configurator /build/nns-dapp-arg* /
# Note: The frontend/.env is kept for use with test deployments only.
Expand Down
1 change: 0 additions & 1 deletion config.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@
"POCKETIC_VERSION": "3.0.1",
"CARGO_SORT_VERSION": "1.0.9",
"SNSDEMO_RELEASE": "release-2026-02-26",
"IC_COMMIT_FOR_PROPOSALS": "release-2026-02-20_12-29-base",
"IC_COMMIT_FOR_SNS_AGGREGATOR": "release-2026-02-20_12-29-base"
},
"packtool": ""
Expand Down
17 changes: 0 additions & 17 deletions declarations/used_by_proposals/nns_governance/proposals.did

This file was deleted.

Loading
Loading