fix(auth): prevent re-entrant logout calls on session expiry#7779
Merged
fix(auth): prevent re-entrant logout calls on session expiry#7779
Conversation
0xFFrancesco
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the session expires,
logout()callsauthStore.signOut()which sets identity tonull. This triggers reactive cascades where in-flight services callgetAuthenticatedIdentity(), see the missing identity, and each independently calllogout()again. Each call appends duplicate URL params via.append()before the browser reloads, which can lead to oversized headers (HTTP 431).Related to: https://forum.dfinity.org/t/proposal-140767-to-upgrade-the-nns-dapp-2026-03-06/65145/4?u=yhabib
Changes
logoutInProgressre-entrancy guard tologout()so only the first call proceeds.appendMsgToUrlfromsearchParams.append()tosearchParams.set()to prevent duplicate URL params as a secondary defense.Tests
signOutand onereload.Todos