Index buffer support for Vertex Buffers#122
Open
JustSid wants to merge 4 commits intodfranx:masterfrom
Open
Conversation
Owner
|
Thank you so much for the PR. I'll give it a try tomorrow. |
Contributor
Author
|
Cool! If you are more comfortable that way, you are more then welcome to fix the formatting upstream and I'll pull them and adjust any issues that are left in the PR. |
…t actually have a buffer bound yet
… associated with it
Contributor
Author
|
I added two crash fixes. The first one is saving a Vertex Buffer object that didn't have buffers associated with it. The other is in the preview UI, where it tries to calculate the bounding volume for the vertex buffer. Same deal here, if there is no buffer associated with it, it'll crash. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds index buffer support for Vertex Buffer objects. I'm using this to prototype some things outside of our game engine, where a compute shader produces a bunch of vertex data and we have a static index buffer for it (that got imported from a file). Although it's not unreasonable to think that generating a index buffer in a compute shader is another use case. Either way, it was something that I felt was missing for my use case.
Also, I realize that this failed the CI check. Unfortunately I have no idea how to parse the output, so I was hoping you could help me with it. The test shows files that I didn't even touch as re-formatted, and there is a ton of noise (I think?) in there that makes it hard to figure out what exactly it would like to have changed.