Don't insert hyphen after existing hyphen during line split. #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
carlobeltrame
added a commit
to carlobeltrame/react-pdf
that referenced
this pull request
Jul 3, 2025
WIP Fixes diegomura#3018, was broken since diegomura#2600 Fixes diegomura#1642 Fixes diegomura#2456 Fixes diegomura#2564 Fixes diegomura#2739 Enables better solutions for diegomura#1238, diegomura#1380, diegomura#1416, diegomura#1662 The hyphenation algorithm may change the string (e.g. by removing some characters, namely soft hyphens). Therefore, calculating the glyphs must come after hyphenation, so that the glyphs match the final string. -> change to the order of text layout engines in textkit Hyphenation algorithm should be able to leave soft hyphens in, to indicate that a hyphen should be placed there if the word breaks there. -> change to the default word hyphenation algorithm in textkit, to split after soft hyphens, but leave the soft hyphens in the syllables The line breaking algorithm needs to distinguish syllables which end with a soft hyphen from syllables that do not, and only mark a syllable for adding a hyphen in the former case. -> change to how hyphenated syllables are detected for the linebreaker algorithms in textkit For the line breaking algorithm, soft hyphens should be considered to have a width of zero, since they are never printed directly (they can only lead to an inserted hyphen if at the end of a line). -> change to distinguish soft hyphens from hyphens in font, this results the glyph to get a zero advanceWidth In the best fit line breaking algorithm, the width of the hyphen must be taken into account, in case one is to be inserted at the end of the line. -> change to the bestFit algorithm in textkit Soft hyphens in the text should not be rendered as hyphens -> change to remove all soft hyphens after linebreaking in linebreaker in textkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #2564. When user provides a hyphenation logic that splits text on existing text, an additional hyphen is added currently.
Before - hyphens are duplicated:
After - hyphens are not duplicated:
Issue reproduction.
I've tested it manually. I don't see existing unit tests for linebreaker.index logic (only for bestFit) and creating them without full understanding of the flow would take me some time.