[prone] Add ConstantNaming
#2687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
pr-StringRulesRecipes
branch
from
a7c3aca to
abac3db
Compare
This was referenced Oct 16, 2025
Pankraz76
force-pushed
the
pr-StringRulesRecipes
branch
3 times, most recently
from
fb844a0 to
a5d95fe
Compare
Pankraz76
commented
Oct 16, 2025
| public class DirtyState { | ||
| @Nullable | ||
| private final byte[] canonicalBytes; | ||
| @Nullable private final byte[] canonicalBytes; |
Contributor
Author
There was a problem hiding this comment.
is this the new way of doing so, or a bug?
As applied in general the formatAnnotations looks quite strange, isn´t it?
Member
There was a problem hiding this comment.
I don't care where it goes, fine with me
Pankraz76
force-pushed
the
pr-StringRulesRecipes
branch
from
a5d95fe to
8228fe0
Compare
This was referenced Oct 16, 2025
nedtwigg
approved these changes
Oct 16, 2025
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
This LGTM. I'm gonna give it 24 more hours before I hit merge in case anyone else wants to chime in.
| public class DirtyState { | ||
| @Nullable | ||
| private final byte[] canonicalBytes; | ||
| @Nullable private final byte[] canonicalBytes; |
Member
There was a problem hiding this comment.
I don't care where it goes, fine with me
This was referenced Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)