feat: Derive createdBy and updatedBy for dataTypes #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Looks solid to me.
Could you also just add a @deprecated tag to $originalVersionIdToDeviceId()?
As you say, we'd get some benefit to caching this, we can wrap in p-memoize with a quick-lru cache with maybe 1000 entries to start - should be plenty for most projects. Happy to add that later since this already is much faster than the current RPC round-trip made for every value.
Hadn't noticed CI failing - this needs fixed before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
Feels like I should do something different for the core ownership case, or maybe have some sort of in-memory cache?