fix: translation fixes and perf improvements #1119
Merged
+88
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only support translations for presets and fields. Attempting to translate other docs is a performance overhead. Makes `getTranslations` optional, and also fixes a possible uncaught error from the translation datatype getTranslations fn
We were cloning docs for both translation and removing null fields, and running several promises in series.
It's faster to get translations including all region codes and filter them, rather than get translations twice, once with a region code and once without.
RangerMauve
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the uncaught errors and performance issues listed in #837.
This also switches to a mutating
deNullify()function. Previously reading docs was cloning twice: once to remove null fields, and then to translate. Translating is also mutating now.This also addresses a perf issue when adding derived fields and translations: previously we were awaiting 3-4 promises in serial (previously there were two translation lookups for many docs). This switches those promises to parallel, and removes one.
The internal types for these functions are too difficult for TS to follow, because of the generics for the class.
NB: Also fixes the return type of getByVersionId(), which was not including the derived fields createdBy and createdAt