Skip to content

fix: NO_ROLE should not sync config core #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

fix: NO_ROLE should not sync config core #1143

merged 2 commits into from
Oct 16, 2025

Conversation

@RangerMauve
Copy link
Contributor

Per this comment: #1138 (comment)

NO_ROLE should not include the config core in case the user's final resolved role doesn't have it.

This might lead to bugs relating to deviceInfo needing to be present, but we'll see in the tests.

gmaclennan
gmaclennan approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good, looks like this passes. I probably added this making incorrect assumptions that it's needed, and it will be better (more secure) with this change

@RangerMauve RangerMauve merged commit 3b0e4d5 into main Oct 16, 2025
11 checks passed
@RangerMauve RangerMauve deleted the fix/no-role-no-config-sync branch October 16, 2025 14:23
gmaclennan added a commit that referenced this pull request Oct 16, 2025
@gmaclennan
Merge branch 'main' into feat/new-comapeocat-format
5550a2b 
* main:
  fix: NO_ROLE should not sync config core (#1143)
  fix: Don't use getAddress in start/stop of local-discovery (#1136)
  chore: update drizzle to v1-beta.1 (#1140)
This was referenced Oct 21, 2025
Closed
Merged
Merged
Merged
Merged
Merged
@gmaclennan gmaclennan mentioned this pull request Oct 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RangerMauve @gmaclennan