chore: semver on release flow #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
approved these changes
Sep 11, 2024
Contributor
EvanHahn
left a comment
EvanHahn
left a comment
There was a problem hiding this comment.
LGTM.
I would personally keep prerelease stuff, but we can add it back as soon as we need it.
Contributor
Author
|
cool, then I'm leaving the commented lines there just in case we want to re-introduce some of this in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the idea is to follow semver, I've went ahead and only allowed (and uncommented)
patch,minorandversionon semver options. We may disagree with this and still have a prerelease (but I think we may not want this).Also I commented some traces of
prereleaserelated to naming the release on github and npm. If approve, I'll remove those commented lines