feat: add /maps/ routes
#2
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment was marked as resolved.
This comment was marked as resolved.
|
Some windows failures around parallel uploads, which I suspect are probably a test artifact rather than a bug to be worried about. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
A couple of small cleanup things to address but otherwise functionality seems thorough!
Out of curiosity, will I still need the patches I have on desktop related to CORS issues that I run into in development? (caused by usage of Vite's dev server)
Slightly tangential, but the publishing tsconfig needs to be updated since you're committing to a TS implementation:
diff --git a/tsconfig.npm.json b/tsconfig.npm.json
index f89cb7b..f35d2b4 100644
--- a/tsconfig.npm.json
+++ b/tsconfig.npm.json
@@ -4,9 +4,7 @@
"noEmit": false,
"outDir": "dist",
"declaration": true,
- "emitDeclarationOnly": true,
"declarationMap": true
},
- "files": [],
- "include": ["src/index.js"]
+ "include": ["src/index.ts", "types/*"]
}| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| node-version: [18.x, 20.x, 22.x] |
There was a problem hiding this comment.
think it could be worth adding 24 here too
| node-version: [18.x, 20.x, 22.x] | |
| node-version: [18.x, 20.x, 22.x, 24.x] |
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v5 |
There was a problem hiding this comment.
thoughts on using latest (v6) and pinning the version for this?
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Set up Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v5 |
There was a problem hiding this comment.
thoughts on using latest (v6) and pinning the version for this?
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: "npm" |
There was a problem hiding this comment.
not necessary to specify if you use latest version of action.
| type SMPStyle = Awaited< | ||
| ReturnType<typeof import('styled-map-package').Reader.prototype.getStyle> | ||
| > |
There was a problem hiding this comment.
isn't this type exported from styled-map-package already?
| // @ts-expect-error - No types available | ||
| import bogon from 'bogon' |
There was a problem hiding this comment.
types package is available for this (assuming it's accurate): https://www.npmjs.com/package/@types/bogon
| "exports": { | ||
| ".": { | ||
| "types": "./dist/index.d.ts", | ||
| "default": "./src/index.js" |
There was a problem hiding this comment.
need to update the publishing tsconfig and then point this to the right directory
| "default": "./dist/index.js" |
There was a problem hiding this comment.
need to specify the files field to something like:
"files: [
"README.md",
"dist"
]
Updates the bounding box used for the map where there's no data to show. Something I learned via digidem/comapeo-map-server#2 (comment)
Updates the bounding box used for the map where there's no data to show. Something I learned via digidem/comapeo-map-server#2 (comment)
Adds routes for reading maps, uploading new custom maps, and deleting custom maps