Skip to content

Conversation

@u4aew
Copy link

@u4aew u4aew commented Dec 14, 2024

Description

Added the ability to theme images by setting data-theme. Support for light and dark themes.

Related issue: #521

@martyanovandrey
Copy link
Contributor

martyanovandrey commented Dec 27, 2024

Thank you for your contribution. At the moment, we're encountering some difficulties with implementing this feature.
As a prerequisite, we need to introduce a 'theme' entity into the transform, which we plan to address in a separate PR.

Once we have successfully integrated the theme, we anticipate relying on the theme set in the <body>, rather than the attribute [data-theme='light/dark'].

Once we've settled on how to support themes in the transform, we will return to this PR for further progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants