-
Notifications
You must be signed in to change notification settings - Fork 62
New OpenAPI Spec #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New OpenAPI Spec #30
Conversation
❌ Deploy Preview for directus-docs-v2 failed. Why did it fail? →
|
…ing references and appending GraphQL and SDK snippets
|
@phazonoverload I have completed converting the json endpoints from the generated oas to the paths folder.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I just left the below comment that's blocking me from a straightforward review. Could you please take a look?
| $ref: paths/permissions/index.yaml | ||
| "/permissions/{id}": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spoke about this with @phazonoverload, is it possible the other paths got removed or not added? Right now I'm only seeing permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding these! I'm afraid I can't get the docs to run now.
Please can you take a look at my comment
api-spec/index.yaml
Outdated
| $ref: paths/users/me/tfa/enable/index.yaml | ||
| "/users/me/track/page": | ||
| $ref: paths/users/me/track/page/index.yaml | ||
| "/utils/cache/clear" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid there's a : missing in this and the next few, giving me this error:
bundling ./api-spec/index.yaml...
Failed to parse API description at ./api-spec/index.yaml:
- can not read an implicit mapping pair; a colon is missed in "/Users/carmenh/directus/docs/api-spec/index.yaml" (122:23)
ELIFECYCLE Command failed with exit code 1.
ELIFECYCLE Command failed with exit code 1.
Adding them then generates a bunch of errors:
[27] api-spec/paths/webhooks/_id/updateWebhook.yaml:53:5 at #/responses/404
Can't resolve $ref: ENOENT: no such file or directory '/Users/carmenh/directus/docs/api-spec/paths/components/responses.yaml'
51 | $ref: ../../components/responses.yaml#/UnauthorizedError
52 | '404':
53 | $ref: ../../components/responses.yaml#/NotFoundError
54 | tags:
55 | - Webhooks
Error was generated by the bundler rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. Very silly of me. Added them now.
❌ Deploy Preview for directus-docs-rewrite failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this!
I've left a number of wording and formatting suggestions that I'm happy to handle myself.
I've also left a number of questions/requests. There's a number of endpoints and code snippets missing from the current documentation.
On a broader note:
- Is it possible to embed vue components into this?
- There is an inconsistent use of an example directus URL and a directus_url variable in code snippets. Can we make this consistent?
- In a few request body breakdowns, we show this
ANYOFtype. What is it? Can we add an explanation to it? See screenshot below.
Thanks in advance!

No description provided.