-
Notifications
You must be signed in to change notification settings - Fork 64
So Many Things #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
So Many Things #39
Conversation
❌ Deploy Preview for directus-docs-v2 failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of notes i couldnt directly find a good place for in the code changes:
-
overlapping icons and labels on the api reference sidebar (in Chrome/light mode)

-
This "collection names are immutable" block seems to have light styling in dark mode

-
The top and side navigations are not sticky which is what i would expect but that may be intentional
-
The top most banner and header navigation are not within a max-width container like the rest of the site (I would expect all 3 to be either full width or containered having 2 out of 3 looks a bit misaligned on larger screens imo)

-
Last but not least there are a ton of accessibility improvements to be gained in keyboard tab order and contrast in both light and dark mode. For example blue text on blue backgrounds, grey text on grey, white text on light purple, white text on light pink and so on (not sure if WCAG has been discussed for the docs)
|
|
||
| env: | ||
| NODE_OPTIONS: --max_old_space_size=6144 | ||
| NUXT_PUBLIC_PRODUCT_DIRECTUS_URL: https://product-team.directus.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NUXT_PUBLIC_PRODUCT_DIRECTUS_URL will also need to be renamed from NUXT_PRODUCT_DIRECTUS_URL in the example.env file
Co-authored-by: Hannes Küttner <[email protected]>
Co-authored-by: Hannes Küttner <[email protected]>
|
Is there any chance we can make the sidenav on the left and the TOC on the right sticky, similar to what supabase does in their docs (https://supabase.com/docs/guides/database/overview) and only switch out the actual page content through a Right now navigating between pages feels super unergonomic and is not a nice experience. |
❌ Deploy Preview for directus-docs-rewrite failed. Why did it fail? →
|
No description provided.