Skip to content

Conversation

@connorwinston
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for directus-docs-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit ddc9793
🔍 Latest deploy log https://app.netlify.com/sites/directus-docs-v2/deploys/6720f5127ed87700086a3a55

Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of notes i couldnt directly find a good place for in the code changes:

  1. overlapping icons and labels on the api reference sidebar (in Chrome/light mode)
    image

  2. This "collection names are immutable" block seems to have light styling in dark mode
    image

  3. The top and side navigations are not sticky which is what i would expect but that may be intentional

  4. The top most banner and header navigation are not within a max-width container like the rest of the site (I would expect all 3 to be either full width or containered having 2 out of 3 looks a bit misaligned on larger screens imo)
    image

  5. Last but not least there are a ton of accessibility improvements to be gained in keyboard tab order and contrast in both light and dark mode. For example blue text on blue backgrounds, grey text on grey, white text on light purple, white text on light pink and so on (not sure if WCAG has been discussed for the docs)


env:
NODE_OPTIONS: --max_old_space_size=6144
NUXT_PUBLIC_PRODUCT_DIRECTUS_URL: https://product-team.directus.app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NUXT_PUBLIC_PRODUCT_DIRECTUS_URL will also need to be renamed from NUXT_PRODUCT_DIRECTUS_URL in the example.env file

@hanneskuettner
Copy link
Member

Is there any chance we can make the sidenav on the left and the TOC on the right sticky, similar to what supabase does in their docs (https://supabase.com/docs/guides/database/overview) and only switch out the actual page content through a <router-view/>/ a common nuxt layout?

Right now navigating between pages feels super unergonomic and is not a nice experience.

@netlify
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for directus-docs-rewrite failed. Why did it fail? →

Name Link
🔨 Latest commit ddc9793
🔍 Latest deploy log https://app.netlify.com/sites/directus-docs-rewrite/deploys/6720f51192fcaa0008ee3059

@connorwinston connorwinston merged commit a6c00ba into main Oct 29, 2024
1 of 3 checks passed
@connorwinston connorwinston deleted the connor/dark-mode-type-fixes branch October 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants