This repository was archived by the owner on Jul 14, 2025. It is now read-only.
FIX: Ensure assign plugin respects prioritize_full_name_in_ux site setting
#632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrusselburg
force-pushed
the
br/full_name
branch
2 times, most recently
from
11ea0aa to
4b1671e
Compare
brrusselburg
commented
Mar 6, 2025
assets/javascripts/discourse/initializers/extend-for-assigns.js
Outdated
Show resolved
Hide resolved
brrusselburg
commented
Mar 6, 2025
assets/javascripts/discourse/initializers/extend-for-assigns.js
Outdated
Show resolved
Hide resolved
brrusselburg
commented
Mar 6, 2025
assets/javascripts/discourse/initializers/extend-for-assigns.js
Outdated
Show resolved
Hide resolved
brrusselburg
commented
Mar 6, 2025
brrusselburg
commented
Mar 6, 2025
brrusselburg
commented
Mar 6, 2025
brrusselburg
commented
Mar 7, 2025
assets/javascripts/discourse/initializers/extend-for-assigns.js
Outdated
Show resolved
Hide resolved
brrusselburg
commented
Mar 7, 2025
brrusselburg
commented
Mar 7, 2025
assets/javascripts/discourse/initializers/extend-for-assigns.js
Outdated
Show resolved
Hide resolved
jdmartinez1062
force-pushed
the
br/full_name
branch
from
1ccf71d to
770d06f
Compare
brrusselburg
commented
Mar 10, 2025
Grubba27
reviewed
Mar 11, 2025
assets/javascripts/discourse/initializers/extend-for-assigns.js
Outdated
Show resolved
Hide resolved
Grubba27
reviewed
Mar 14, 2025
spec/system/assign_post_spec.rb
Outdated
Comment on lines
134
to
145
| topic_page.click_assign_post(post2) | ||
| assign_modal.assignee = staff_user | ||
| assign_modal.confirm | ||
|
|
||
| expect(assign_modal).to be_closed | ||
| expect(topic_page).to have_assigned_post(user: staff_user, at_post: 3) | ||
|
|
||
| find(".timeline-controls .toggle-admin-menu").click | ||
| find(".topic-admin-close").click | ||
|
|
||
| expect(find("#post_4")).to have_content( | ||
| I18n.t("js.action_codes.closed.enabled", when: "just now"), |
There was a problem hiding this comment.
This piece repeats a bit(3 times I think) we could do an abstraction on top of it
Grubba27
approved these changes
Mar 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the assign plugin with the hidden setting
prioritize_full_name_in_ux. When this setting is true, the user's full name will be shown (if it exists) instead of username.Before
After