Skip to content

Remove dirfd definition for spawnProcessPosix #10976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd86k wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −5
Open

Remove dirfd definition for spawnProcessPosix #10976

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a85a5f6
Define dirfd macro for NetBSD
dd86k Mar 16, 2026
9f63d47
std.process: Locally import dirfd for spawnProcessPosix
dd86k Mar 17, 2026
769707f
Bump
0xEAB Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions std/process.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ private Pid spawnProcessPosix(scope const(char[])[] args,
{
void fallback (int lowfd)
{
import core.sys.posix.dirent : dirent, opendir, readdir, closedir, DIR;
import core.sys.posix.dirent : dirfd, dirent, opendir, readdir, closedir, DIR;
import core.sys.posix.unistd : close;
import core.sys.posix.stdlib : atoi, malloc, free;
import core.sys.posix.sys.resource : rlimit, getrlimit, RLIMIT_NOFILE;
Expand All @@ -1048,10 +1048,6 @@ private Pid spawnProcessPosix(scope const(char[])[] args,

immutable maxDescriptors = cast(int) r.rlim_cur;

// Missing druntime declaration
pragma(mangle, "dirfd")
extern(C) nothrow @nogc int dirfd(DIR* dir);

DIR* dir = null;

// We read from /dev/fd or /proc/self/fd only if the limit is high enough
Expand Down
Loading