Support 32-bit mode flags and SPI_MOSI_IDLE_LOW #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2025
Since Linux 3.15 (11 years ago) the size of the mode field was increased from 8 to 32 bits. In order to support some of the newer mode flags (above the first 8 bits), let's switch to use the new ioctls and store a 32 bit value in SpiDevObject. This breaks the compatibility with Linux kernel versions before v3.15. Signed-off-by: Frieder Schrempf <[email protected]>
Add a new attribute 'idle_low' to get/set the state of the SPI_MOSI_IDLE_LOW flag. If enabled the MOSI line is low when idle. This needs to be supported by the controller driver. This flag is available in the kernel since v6.5. This solves doceme#136. Signed-off-by: Oualid Derouiche <[email protected]> Signed-off-by: Frieder Schrempf <[email protected]>
fschrempf
force-pushed
the
feature/idle-low-flag
branch
from
131b7b7 to
16a3b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linux 3.15 (11 years ago) the size of the mode field was increased from 8 to 32 bits. In order to support some of the newer mode flags like
SPI_MOSI_IDLE_LOW, let's switch to use the new ioctls and store a 32 bit value in SpiDevObject.This breaks the compatibility with Linux kernel versions before v3.15.
The support for the
mosi_idle_lowattribute is wrapped in#ifdef SPI_MOSI_IDLE_LOWto make sure the module still compiles when using kernel header versions before v6.5 where support forSPI_MOSI_IDLE_LOWwas added.This solves #136.