Skip to content

Conversation

alingse
Copy link

@alingse alingse commented Apr 2, 2025

xyz.go:55:13: SA6005: should use strings.EqualFold instead (staticcheck)
} else if strings.ToUpper(a) != strings.ToUpper(b) {

this message may cause some misstake when copy the method and change it to

} else if strings.EqualFold(a, b) {

a better tips we think should be

xyz.go:55:13: SA6005: should use !strings.EqualFold instead (staticcheck)
} else if strings.ToUpper(a) != strings.ToUpper(b) {

alingse added 2 commits April 2, 2025 15:34
should give a correct tips
@alingse alingse changed the title Update sa6005.go, give a better tips update sa6005 use !strings.EqualFold when token is NEQ Apr 5, 2025
@alingse alingse changed the title update sa6005 use !strings.EqualFold when token is NEQ update sa6005: tips use !strings.EqualFold when token is NEQ Apr 5, 2025
@alingse
Copy link
Author

alingse commented Apr 11, 2025

@dominikh how do you think? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant