Merged
Conversation
…36936) * Initial plan * Add content about enabling CORS for SignalR without applying the policy globally Add a new subsection "Apply a CORS policy to SignalR hub endpoints" under the CORS section in SignalR security docs. Documents two approaches: 1. Using RequireCors on the MapHub endpoint mapping 2. Using the [EnableCors] attribute on the Hub class Applied across all relevant moniker versions (8.0+, 7.0, 6.0, 3.0-5.x). Agent-Logs-Url: https://github.com/dotnet/AspNetCore.Docs/sessions/c6bf092e-343b-49ad-bfa1-e83078d9e265 Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com> * Add named CORS policy registration example to SignalR hub CORS subsection Show the AddCors/AddPolicy snippet that defines "SignalRPolicy" before it's referenced in the RequireCors and [EnableCors] examples. Agent-Logs-Url: https://github.com/dotnet/AspNetCore.Docs/sessions/eeaca9de-513b-4a43-a838-4e3f6ca91450 Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com> * Add author information to security.md * Apply suggestion from @wadepickett * Apply suggestions from code review Co-authored-by: Wade Pickett <wpickett@microsoft.com> * Apply suggestions from code review Co-authored-by: Wade Pickett <wpickett@microsoft.com> * Revert changes to security2.1-5.md, security6.md, and security7.md Per BrennanConroy's feedback, these are unsupported versions and don't need the CORS documentation update. The new CORS subsection is retained only in security.md (aspnetcore 8.0+). Agent-Logs-Url: https://github.com/dotnet/AspNetCore.Docs/sessions/c741589c-d9d2-40d2-ad8e-14eed4304350 Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com> Co-authored-by: Wade Pickett <wpickett@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AUTOMATED]