[Draft] Azure Split - Step 3 - Tie Everything Together #3908

paulmedynski · 2026-01-22T15:41:03Z

Description

This PR ties everything together:

Removes Azure authentication files from the MDS projects.
Adds dependencies to the Abstractions package everywhere necessary.
Updates pipelines to include Abstractions and Azure packages where necessary.
Removed some unnecessary flexibility in the MDS official pipeline.

PR series:

Azure Split - Step 1 - Prep Work #3902:
- Merge changes that aren't directly related to the Azure split work, but that setup the stage for that work.
Azure Split - Step 2 - New Files #3904:
- Merge new files and related changes that do not affect the existing MDS projects or artifacts.
[Draft] Azure Split - Step 3 - Tie Everything Together #3908:
- Merge the changes to MDS and pipelines that tie everything together.
Step 4:
- Any remaining tasks or cleanup.

Testing

Normal PR/CI pipeline runs will validate most changes.
Manual inspection of pipeline logs and artifacts will confirm some of the fiddly parts.

…ogether - Brought over all of the remaining code and project changes.

…ogether - Brought over the pipeline changes. - Removed unnecessary flexibility from the MDS official pipeline tree.

Copilot

Pull request overview

This pull request is the third step in the Azure Split work, which removes Azure authentication implementation from the main SqlClient project and establishes dependencies on the new Abstractions package. The PR removes Azure-specific authentication code, updates project dependencies, adds test authentication providers, and updates CI/CD pipelines to handle the new package structure.

Changes:

Removes ActiveDirectoryAuthenticationProvider, SqlAuthenticationProvider, SqlAuthenticationToken, SqlAuthenticationParameters, and related Azure authentication classes from the MDS source
Adds dependency on Microsoft.Data.SqlClient.Extensions.Abstractions package across all MDS projects (src and ref)
Updates test infrastructure with UsernamePasswordProvider and ManagedIdentityProvider implementations for manual tests
Updates all pipeline YAML files to include AbstractionsPackageVersion parameter and propagate it through build and test steps

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/specs/Microsoft.Data.SqlClient.nuspec	Adds Abstractions package dependency to all target frameworks
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs	Implements dynamic loading of Azure extension package as default provider
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs	Refactors token acquisition retry logic to use new exception model
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/*.cs	Adds test authentication providers
src/Microsoft.Data.SqlClient/**/Microsoft.Data.SqlClient.csproj	Removes Azure.* package references, adds Abstractions reference
eng/pipelines/*/.yml	Adds AbstractionsPackageVersion parameter throughout

Copilot · 2026-01-22T15:46:10Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

+                foreach (SqlAuthenticationMethod candidateMethod in Instance._authenticationsWithAppSpecifiedProvider)
                {
                    if (candidateMethod == authenticationMethod)
                    {
-                        _sqlAuthLogger.LogError(nameof(SqlAuthenticationProviderManager), methodName, $"Failed to add provider {GetProviderType(provider)} because a user-defined provider with type {GetProviderType(_providers[authenticationMethod])} already existed for authentication {authenticationMethod}.");
-                        return false; // return here to avoid replacing user-defined provider
+                        Instance._sqlAuthLogger.LogError(nameof(SqlAuthenticationProviderManager), methodName, $"Failed to add provider {GetProviderType(provider)} because a user-defined provider with type {GetProviderType(Instance._providers[authenticationMethod])} already existed for authentication {authenticationMethod}.");
+
+                        // The app has already specified a Provider for this
+                        // authentication method, so we won't override it.
+                        return false;
                    }
                }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2026-01-22T15:46:10Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs

-                                // Use Connection timeout value to cancel token acquire request
-                                // after certain period of time.(int)
-                                if (_timeout.MillisecondsRemaining < int.MaxValue)
+                                CancellationTokenSource cts = new();


Disposable 'CancellationTokenSource' is created but not disposed.

Suggested change

CancellationTokenSource cts = new();

using CancellationTokenSource cts = new();

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/UsernamePasswordProvider.cs

…ogether - Removed Azure parameters from CI test tree.

…ogether - Fixed missing Abstractions and MDS package version parameters.

Copilot

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated no new comments.

edwardneal · 2026-01-22T18:27:16Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs

+                    int retryPeriod =
+                      ex.RetryPeriod > 0
+                      ? ex.RetryPeriod
+                      : defaultRetryPeriod * (2 ^ attempt);


Suggested change

: defaultRetryPeriod * (2 ^ attempt);

: defaultRetryPeriod * (1 << attempt);

edwardneal · 2026-01-22T19:09:34Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

-                var activeDirectoryAuthProvider = new ActiveDirectoryAuthenticationProvider(instance._applicationClientId);
-                instance.SetProvider(SqlAuthenticationMethod.ActiveDirectoryIntegrated, activeDirectoryAuthProvider);
+                // Try to load our Azure extension.
+                var assembly = Assembly.Load(assemblyName);


To back up your TODO, this'll need to be loaded with a strong name, otherwise a client which doesn't use Azure connectivity will load any assembly at [application base]/Microsoft.Data.SqlClient.Extensions.Azure/Microsoft.Data.SqlClient.Extensions.Azure.dll and pass this any Azure credentials.

With the assembly signature verified by including the public key token in the assembly name, maybe we could simplify the load process and directly use Type.GetType with a fully-qualified assembly name.

codecov · 2026-01-23T11:56:15Z

Codecov Report

❌ Patch coverage is 52.57732% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.78%. Comparing base (e4fdb36) to head (16a3cd8).

Files with missing lines	Patch %	Lines
...Data/SqlClient/SqlAuthenticationProviderManager.cs	44.33%	59 Missing ⚠️
...Data/SqlClient/Connection/SqlConnectionInternal.cs	53.12%	15 Missing ⚠️
...ta/SqlClient/SqlAuthenticationParametersBuilder.cs	77.55%	11 Missing ⚠️
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs	0.00%	7 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           dev/paul/azure/step2    #3908      +/-   ##
========================================================
- Coverage                 69.92%   69.78%   -0.15%     
========================================================
  Files                       263      260       -3     
  Lines                     66190    65694     -496     
========================================================
- Hits                      46285    45844     -441     
+ Misses                    19905    19850      -55

Flag	Coverage Δ
netcore	`69.74% <49.48%> (-0.18%)`	⬇️
netfx	`68.98% <52.57%> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski added 2 commits January 22, 2026 09:12

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

5fd1f64

…ogether - Brought over all of the remaining code and project changes.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

e90b605

…ogether - Brought over the pipeline changes. - Removed unnecessary flexibility from the MDS official pipeline tree.

paulmedynski added this to the 7.0.0-preview4 milestone Jan 22, 2026

paulmedynski added the Area\Azure Connectivity Use this to tag issues that are related to Azure connectivity. label Jan 22, 2026

Copilot AI review requested due to automatic review settings January 22, 2026 15:41

This was referenced Jan 22, 2026

Azure Split - Step 2 - New Files #3904

Open

Azure Split - Step 1 - Prep Work #3902

Open

Copilot started reviewing on behalf of paulmedynski January 22, 2026 15:41 View session

paulmedynski mentioned this pull request Jan 22, 2026

[DO NOT MERGE] Visuazlie diffs of feat/azure split #3901

Draft

Copilot AI reviewed Jan 22, 2026

View reviewed changes

paulmedynski added 2 commits January 22, 2026 12:15

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

f968d92

…ogether - Removed Azure parameters from CI test tree.

Task 41737: Merge feat/azure-split to main: Step 3 - Tie everything t…

16a3cd8

…ogether - Fixed missing Abstractions and MDS package version parameters.

Copilot AI review requested due to automatic review settings January 22, 2026 16:26

Copilot started reviewing on behalf of paulmedynski January 22, 2026 16:27 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

edwardneal reviewed Jan 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Draft] Azure Split - Step 3 - Tie Everything Together #3908

[Draft] Azure Split - Step 3 - Tie Everything Together #3908

paulmedynski commented Jan 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

edwardneal Jan 22, 2026

Uh oh!

edwardneal Jan 22, 2026

Uh oh!

codecov bot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	CancellationTokenSource cts = new();
	using CancellationTokenSource cts = new();

	: defaultRetryPeriod * (2 ^ attempt);
	: defaultRetryPeriod * (1 << attempt);

[Draft] Azure Split - Step 3 - Tie Everything Together #3908

Are you sure you want to change the base?

[Draft] Azure Split - Step 3 - Tie Everything Together #3908

Conversation

paulmedynski commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

edwardneal Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

edwardneal Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 23, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paulmedynski commented Jan 22, 2026 •

edited

Loading