Skip to content

Draft grammar to permit nullable types as array element types. #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: draft-v8
Choose a base branch
from
Draft

Draft grammar to permit nullable types as array element types. #1297

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e6d7e
Draft grammar to permit nullable types as array element types.
gafter Mar 19, 2025
2037e3f
Fix markdown.
gafter Mar 19, 2025
c512872
Attempt to remove left recursion.
gafter Mar 19, 2025
71b95ec
Fix grammar
gafter Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions standard/types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ interface_type
;

array_type
: non_array_type rank_specifier+
| non_array_type rank_specifier+
| non_array_type ( nullable_type_annotation rank_specifier+ )+
Copy link
Contributor

@jnm2 jnm2 Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this allow int??[]?

Copy link
Member Author

@gafter gafter Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because a nullable type isn't a non_array_type.

Copy link
Contributor

@jnm2 jnm2 Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading it right, non_array_type includes value_type which includes nullable_value_type which I believe int? would be.

;

non_array_type
Expand All @@ -64,7 +65,6 @@ non_array_type
| delegate_type
| 'dynamic'
| type_parameter
| nullable_reference_type
| pointer_type // unsafe code support
;

Expand Down
Loading