-
Notifications
You must be signed in to change notification settings - Fork 6k
Don't disallow adding a DIM to an interface #48801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks so much for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gewarren
This looks good, with a few small changes.
Co-authored-by: Bill Wagner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates documentation and rules regarding default interface members (DIMs) to clarify that adding a DIM to an interface is not strictly disallowed, but requires judgment. The changes correct terminology and reorganize content for better flow.
- Updates library change rules to allow adding static, non-abstract, non-virtual members to interfaces in certain scenarios
- Corrects terminology from "default interface methods" to "default interface members" for consistency
- Reorganizes the interface keyword documentation to improve readability and flow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
docs/core/compatibility/library-change-rules.md | Updates breaking change rules to allow adding DIMs to interfaces with judgment, removes extra whitespace |
docs/csharp/language-reference/keywords/interface.md | Reorganizes content structure and corrects access modifier descriptions for better clarity |
docs/csharp/whats-new/csharp-version-history.md | Corrects terminology from "methods" to "members" and fixes comma placement |
Co-authored-by: Copilot <[email protected]>
Fixes #42748.
Also reorganizes interface keyword doc as it didn't seem to flow properly.
cc @jskeet.
Internal previews