[iOS] Add a done button to text fields

[kubaflo]

Description of Change

When specifying Keyboard="Numeric/Plain/Telephone", the resulting keyboard on iOS lacks a dedicated "Done" button, making it difficult for users to dismiss the keyboard. This issue is further exacerbated by the fact that sometimes tapping outside the keyboard does not automatically hide it, leading to a frustrating user experience.

Issues Fixed

Fixes #24644
Fixes #19550
Fixes #29370

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-09-07.at.12.50.48.mp4

[mattleibow]

@kubaflo is your description for another PR? It says ripple and button, but the PR is for iOS and Done.

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

Editor already has this logic in Core, should this rather be added there as a feature?

[kubaflo]

@kubaflo is your description for another PR? It says ripple and button, but the PR is for iOS and Done.

@mattleibow my bad 😅 I initially copied and pasted from this PR: #23599

[kubaflo]

Editor already has this logic in Core, should this rather be added there as a feature?

@mattleibow Yes that's right, editors have this button always enabled

[mattleibow]

@PureWeen maybe this is better in Core for all Entry instances? Also, what if the user wants to hide from Editor? We added this for Editor without a way to disable, so maybe we need to come up with an API or something for net9.0?

[mattleibow]

@tj-devel709 You are our resident "text entry" person/expert/guru...

[mattleibow]

After a chat with some folks, I think this is worth making into an actual feature. We already do this for Editor, so making this work the same for Entry is a better thing.

Could this PR be updated to rather be a .NET 9 feature that basically always adds the Done button to Entry - just like we have in Editor.

[kubaflo]

After a chat with some folks, I think this is worth making into an actual feature. We already do this for Editor, so making this work the same for Entry is a better thing.

Could this PR be updated to rather be a .NET 9 feature that basically always adds the Done button to Entry - just like we have in Editor.

No problem, I will do it soon!

[kubaflo]

@mattleibow done :)

[jsuarezruiz]

/azp run

[PureWeen]

After a chat with some folks, I think this is worth making into an actual feature. We already do this for Editor, so making this work the same for Entry is a better thing.
Could this PR be updated to rather be a .NET 9 feature that basically always adds the Done button to Entry - just like we have in Editor.

Hm not sure who you talked to, but I'd love to discuss this a bit more. Adding a (visual) breaking change without a way to opt-out doesn't sound like a great thing to me.

It would make more sense to me to implement what we wanted to do originally here: make a platform-specific (or setting, if it is relevant to more platforms) that allows to customize this behavior for both the Entry and the Editor. Ideally with the setting set to true by default for the Editor since it's already on there and false for the Entry because we don't have it there today.

That way people can opt-in/out when they want but it doesn't change the default behavior of their apps today.

@mattleibow ?

[PureWeen]

/rebase

[PureWeen]

/azp run

[Copilot]

Pull Request Overview

This PR adds a "Done" button to text fields and editors on iOS by implementing a reusable input accessory view. This addresses user experience issues where keyboards without dedicated "Done" buttons (such as Numeric, Plain, and Telephone keyboards) make it difficult for users to dismiss the keyboard, especially when tapping outside doesn't hide it.

• Refactors existing editor "Done" button functionality into reusable extension methods
• Adds "Done" button support to Entry controls (previously only available for Editor)
• Creates consistent behavior across both Entry and Editor controls for keyboard dismissal

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/Core/src/Platform/iOS/TextViewExtensions.cs	Adds extension method to attach Done accessory view to UITextView with editor-specific completion handling
src/Core/src/Platform/iOS/TextFieldExtensions.cs	Adds extension method to attach Done accessory view to UITextField with entry-specific completion handling
src/Core/src/Handlers/Entry/EntryHandler.iOS.cs	Updates Entry handler to use new Done accessory view extension method
src/Core/src/Handlers/Editor/EditorHandler.iOS.cs	Refactors existing Done button code to use new extension method

Comments suppressed due to low confidence (1)

src/Core/src/Platform/iOS/TextViewExtensions.cs:193

• The variable name 'entryHandler' is misleading since this is in TextViewExtensions and handles IEditorHandler. It should be renamed to 'editorHandler' for clarity.

			if (sender is IEditorHandler entryHandler)

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

@kubaflo can you fix tests on this one and rebase?

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jfversluis]

Let's do this. We can always add a opt-in/opt-out for it later!