[Android] Fixed Picker Does Not Show Selected Item Highlight #29979

NanthiniMahalingam · 2025-06-13T12:37:49Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

The Picker control does not display a selected item indication on the Android platform.

Root Cause

On Android, when an item is selected in the Picker dialog, there is no visual indication of the selected item due to missing support for selection highlighting.

Description of Changes

Implemented the SetSingleChoiceItems method to visually indicate the selected item in the Picker dialog.
Used MaterialAlertDialogBuilder to enable customization of the Picker dialog appearance.
Applied materialAlertDialogTheme to maintain consistent styling for both light and dark themes.

Validated the behaviour in the following platforms

Android
Windows ,
iOS,
MacOS

Issues Fixed

Fixes #29633
Fixes #19681

Output Images
Android

Before	After
Light Mode

Dark Mode

dotnet-policy-service · 2025-06-13T12:38:07Z

Hey there @@NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR addresses the Android Picker control issue by introducing visual indication for the selected item in the Picker dialog.

Updated styles to include the materialAlertDialogTheme for consistent theming.
Replaced the AppCompatAlertDialog with MaterialAlertDialogBuilder and changed the item selection method to SetSingleChoiceItems for pre-selecting the current item.
Added automated tests and a host app sample to verify the new behavior.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File	Description
src/Core/src/Platform/Android/Resources/values/styles.xml	Added materialAlertDialogTheme reference for consistent theming.
src/Core/src/Handlers/Picker/PickerHandler.Android.cs	Updated dialog creation to use MaterialAlertDialogBuilder and SetSingleChoiceItems for selection highlighting.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29633.cs	Added a test to ensure the Picker displays a selected item highlight.
src/Controls/tests/TestCases.HostApp/Issues/Issue29633.cs	Added a sample page demonstrating the highlighted Picker behavior.

jsuarezruiz · 2025-06-16T05:53:06Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-16T05:53:17Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29633.cs

mattleibow · 2025-06-27T01:32:05Z

src/Core/src/Handlers/Picker/PickerHandler.Android.cs

-				using (var builder = new AppCompatAlertDialog.Builder(Context))
+				using (var builder = new MaterialAlertDialogBuilder(Context))


Do we need to switch the control? I worry that for net9 this may cause issues with styling as none of the other dialogs are material. We got things like buttons and toolbars, but this full switch may need to wait for net10.

The single selection does exist:
https://developer.android.com/reference/androidx/appcompat/app/AlertDialog.Builder#setSingleChoiceItems(java.lang.CharSequence[],int,android.content.DialogInterface.OnClickListener)

mattleibow · 2025-06-27T01:34:40Z

src/Core/src/Platform/Android/Resources/values/styles.xml

        <item name="alertDialogTheme">@style/MauiAlertDialogTheme</item>
+        <item name="materialAlertDialogTheme">@style/MauiAlertDialogTheme</item>


I see we use the same material dilog style for both material and app compat, but still might be worth not changing too much in net9.

Maybe for net10 we switch all the pickers to material? But that is a different issue.

…net#26153) * Don’t call NSAttributedString with HTML from a background thread * Added a UITest * Refactor * add more comments and move to Controls --------- Co-authored-by: Matthew Leibowitz <[email protected]>

…ge class (dotnet#29138) * Fix for GraphicsView ImagePaint * update for the graphics view imagePaint * Added testcase * Implementation for Downsize * Revert "Added testcase" This reverts commit ef22fa8. * Added test case * Added CreateResizedMethod * Implemented Resize method * Fix modification * Added testcase * Revert "Added test case" This reverts commit a79de0d. * Updated the changes * Update changes * Updated the testcase * Commited the changes * Updating code * Update TestCase * Code Update * Modify TestCase * TestCase Updation * Code update * Adding Snapshots * Added snapshots * Revert "Added snapshots" This reverts commit cac6f45. * Refactor code

* Initial plan for issue * Update TSA areaPath from "DevDiv\\VS Client - Runtime SDKs\\MAUI" to "DevDiv\\.NET MAUI\\MAUI" Co-authored-by: Aguilex <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Aguilex <[email protected]>

* [ci] try do full build on dnceng Update stage-build.yml Update stage-build.yml Update stage-build.yml Update stage-build.yml Update stage-build.yml Update stage-build.yml * Remove the jdk step * Fix provisioning * [tests] Try fix GC flaky tests * [tests] Refactor to use GC test helpers * Build on macos and windows * remove pool * Fix display name * try this * try again * Revert "try this" This reverts commit f55e3c7. * Revert "try again" This reverts commit 85eab97. * again * Build platform * again * buildConfigurations * go back * Release * variable * Add prepare steps * again * Buildplatform * OS * add vmImage * Fix build script * Try fix TestHelper collect * Fix _buildScriptMacOS * Add TreatWarningsAsErrors variable * Try fix path * Fix paths * Try fix leaks * Refactor _BuildConfig * again * Fix pack log * -warnAsError 0 * Try this setting * Fix scripts * Add Helix * Add Helix script * Add helix * change name * Try again * Try restore first * Add helix cmd * Add missing parameters * No node reuse * Setup machine first * try again * try condition * again * again * Fix * ident * again * if * again * Build and pack * Update .net9 eng * Try helix in debug * fix bl * remove bl * don t run unit test * Run tests in release/debug * Try again * Fix stage * Try fix script * Build buildstasks * we need restore on this too * Try $(Build.SourcesDirectory) * Fix variables * Update * this works? * [iOS] Add CodesignRequireProvisioningProfile=false * [tests] Fix more leak tests * Just run xunit tests for now * Try publish missing assemblies * [ci] Update arcade versions * add TreatWarningsAsErrors=$(TreatWarningsAsErrors * Try -nowarn * Try fix display names * back * test_helix_unit_tests * again * Test * Try set friendly name * Try run other tests * Skip failing test * Fix name * Revert "Try set friendly name" This reverts commit af22e7c. * Try fix test warn * Fix warn as error * Add more tests * Fix helix * try run on mac too * [testing] Skipping some tests don t work on helix * [tests] Skip some failing tests * Try to spend more time on build mac * Publish needed packages * [tests] don t run resizetizer tests * [tests] Cleanup testhelper * [ci] Update xharness * [ci] Try to pass env variable to integration tests * Try again * Update AppleTemplateTests.cs * Update TestHelpers.cs * Update TestHelpers.cs * dont run iOS tests on dotnet previous * [testing] Fix helper method * [testint] Don t skip BindingUnsubscribesForDeadTarget

) * Add overrides to Help with Obsoleting Compatibility.Layout * - fix spelling * - fix API txt file * - fix comments * - tizen

* Adding different options to generate adb keys * More changes

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Initial plan for issue * Update README with link to .NET 10 Co-authored-by: rachelkang <[email protected]> * Update date format for .NET 10 announcement Co-authored-by: mattleibow <[email protected]> * Remove .NET 10 entry from README based on feedback Co-authored-by: jsuarezruiz <[email protected]> * Re-add .NET 10 link with just the year 2025 Co-authored-by: jsuarezruiz <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: rachelkang <[email protected]> Co-authored-by: mattleibow <[email protected]> Co-authored-by: jsuarezruiz <[email protected]>

…tnet#30117) * Initial plan for issue * Fix update-cgmanifest.ps1 to generate deterministic output Co-authored-by: mattleibow <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mattleibow <[email protected]>

…ines (dotnet#30230) * Initial plan * Add code formatting instructions to copilot-instructions.md Co-authored-by: mattleibow <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mattleibow <[email protected]>

* Build the project forst before formatting * We may need to restore... * Update dotnet-format-daily.yml

…sisBannedApiAnalyzers to 4.14.0 (dotnet#30213) * Initial plan * Update analyzer versions and fix initial Graphics API issues Co-authored-by: PureWeen <[email protected]> * Add missing public APIs for netstandard2.0 and netstandard2.1 Core project Co-authored-by: PureWeen <[email protected]> * Fix Controls.Core public API issues for netstandard builds Co-authored-by: PureWeen <[email protected]> * Fix Controls.Core compile errors by adding missing public APIs for all target frameworks Co-authored-by: PureWeen <[email protected]> * Fix iOS public API duplicates by removing entries already in Shipped.txt Co-authored-by: PureWeen <[email protected]> * Fix MacCatalyst public API duplicates by removing iOS lifecycle events already in Shipped.txt Co-authored-by: PureWeen <[email protected]> * - fix iOS * - fix catalyst and ios * - fix * - fix windows * - fix windows * Fix Maps project build errors by adding missing public API declarations for MapElementHandlerUpdate record Co-authored-by: PureWeen <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: PureWeen <[email protected]> Co-authored-by: Shane Neuville <[email protected]>

…ldNotHangOrCrash in CI that occasionally fails (dotnet#30239) * fixed flaky test 8870 * Update src/TestUtils/src/UITest.Appium/HelperExtensions.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>

jsuarezruiz · 2025-06-30T06:13:27Z

I noticed the PR might include some unintended changes, possibly due to a misstep during rebase. Would you mind taking a quick look to confirm?

…ead (dotnet#26153)" This reverts commit 61ee829.

NanthiniMahalingam · 2025-07-01T12:11:55Z

Closing this one in favor of #30345

dotnet-policy-service bot added the community ✨ Community Contribution label Jun 13, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jun 13, 2025

NanthiniMahalingam changed the title ~~Fix 29633~~ [Android] Fixed Picker Does Not Show Selected Item Highlight Jun 13, 2025

NanthiniMahalingam marked this pull request as ready for review June 13, 2025 12:58

Copilot AI review requested due to automatic review settings June 13, 2025 12:58

NanthiniMahalingam requested a review from a team as a code owner June 13, 2025 12:58

NanthiniMahalingam requested review from PureWeen and jsuarezruiz June 13, 2025 12:58

Copilot AI reviewed Jun 13, 2025

View reviewed changes

jsuarezruiz suggested changes Jun 16, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29633.cs Show resolved Hide resolved

PureWeen added this to MAUI SDK Ongoing Jun 25, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Jun 25, 2025

PureWeen added this to the .NET 9 SR9 milestone Jun 25, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Jun 25, 2025

mattleibow requested changes Jun 27, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Jun 27, 2025

NanthiniMahalingam force-pushed the fix-29633 branch from 6f0453e to 25a5ad2 Compare June 27, 2025 13:39

NanthiniMahalingam changed the base branch from main to net10.0 June 27, 2025 13:44

kubaflo and others added 9 commits June 27, 2025 19:20

Update copilot-instructions.md with PR testing notes (dotnet#30138)

8afa005

Add overrides to Help with Obsoleting Compatibility.Layout (dotnet#30058

61f1ab8

) * Add overrides to Help with Obsoleting Compatibility.Layout * - fix spelling * - fix API txt file * - fix comments * - tizen

Clean up unreferenced API Docs XML files (dotnet#30141)

17ca7d3

[Testing] Fix ADB Key Generation Failure on CI (dotnet#30092)

b8be5f5

* Adding different options to generate adb keys * More changes

[create-pull-request] automated change (dotnet#30185)

910a76d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot AI and others added 17 commits June 27, 2025 19:25

Use the known working version of platform-tools (dotnet#30173)

9f0ede8

Update Issue8870.cs (dotnet#30200)

9fd9b33

[ci] Add a way to open insiders to cake (dotnet#30211)

e4ec490

Update dotnet-format-daily.yml (dotnet#30231)

cecf058

Build the project first before formatting (dotnet#30233)

7c78fff

* Build the project forst before formatting * We may need to restore... * Update dotnet-format-daily.yml

Fixed the picker selection issue on android platform

ffeef4d

Updated the fix

0d58720

Updated the fix.

f431390

Added the test case

bf42130

Updated the test case

fa7be51

Added output images

3dfbb48

Added the output images

c985abb

NanthiniMahalingam force-pushed the fix-29633 branch from 25a5ad2 to c985abb Compare June 27, 2025 13:58

Revert "Don’t call NSAttributedString with HTML from a background thr…

f130fba

…ead (dotnet#26153)" This reverts commit 61ee829.

NanthiniMahalingam closed this Jul 1, 2025

github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Jul 1, 2025

NanthiniMahalingam deleted the fix-29633 branch July 21, 2025 07:33

github-actions bot locked and limited conversation to collaborators Aug 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Android] Fixed Picker Does Not Show Selected Item Highlight #29979

[Android] Fixed Picker Does Not Show Selected Item Highlight #29979

Uh oh!

NanthiniMahalingam commented Jun 13, 2025 •

edited by PureWeen

Loading

Uh oh!

dotnet-policy-service bot commented Jun 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

jsuarezruiz commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

Uh oh!

mattleibow Jun 27, 2025

Uh oh!

mattleibow Jun 27, 2025

Uh oh!

jsuarezruiz commented Jun 30, 2025

Uh oh!

NanthiniMahalingam commented Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

		using (var builder = new AppCompatAlertDialog.Builder(Context))
		using (var builder = new MaterialAlertDialogBuilder(Context))

		<item name="alertDialogTheme">@style/MauiAlertDialogTheme</item>
		<item name="materialAlertDialogTheme">@style/MauiAlertDialogTheme</item>

[Android] Fixed Picker Does Not Show Selected Item Highlight #29979

[Android] Fixed Picker Does Not Show Selected Item Highlight #29979

Uh oh!

Conversation

NanthiniMahalingam commented Jun 13, 2025 • edited by PureWeen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Jun 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

jsuarezruiz commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

Uh oh!

mattleibow Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

mattleibow Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jun 30, 2025

Uh oh!

NanthiniMahalingam commented Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

NanthiniMahalingam commented Jun 13, 2025 •

edited by PureWeen

Loading