[release/10.0.1xx-preview6] Merge net10.0 to preview 6 #30344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler (#29887) * Add null check for ItemsSource before Selection/ Deselection * Add an UI test * Update null check * more null checks * Update namespace * update namespace again
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Changes in provisioning to fix fails installing Appium on Linux * Fix mistake * More changes, try to install appium drivers with elevated privileges (if normal install fails) * More changes * Display the installed drivers
* Initial plan for issue * Initial assessment and plan for Copilot development environment setup Co-authored-by: PureWeen <[email protected]> * Add comprehensive GitHub Copilot development environment instructions Co-authored-by: PureWeen <[email protected]> * Remove dotnet workload restore recommendations and enhance with DEVELOPMENT.md content Co-authored-by: PureWeen <[email protected]> * Address feedback: remove platform build commands, simplify instructions, add platform folder info Co-authored-by: PureWeen <[email protected]> * Remove cgmanifest.json and templatestrings.json files from PR and update .NET version info Co-authored-by: PureWeen <[email protected]> * Add note about DeviceTest projects not working with dotnet test Co-authored-by: PureWeen <[email protected]> * Address feedback: remove sections, fix branch name, add test paths Co-authored-by: jonathanpeppers <[email protected]> * Address all feedback: remove sections, add platform-specific file extensions info Co-authored-by: PureWeen <[email protected]> * Remove DeviceTest references and combine testing sections Co-authored-by: PureWeen <[email protected]> * Add additional test projects and remove "run all tests" instruction Co-authored-by: PureWeen <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: PureWeen <[email protected]> Co-authored-by: jonathanpeppers <[email protected]>
* Recover the uitest-build task on Android cake * Update android.cake --------- Co-authored-by: Shane Neuville <[email protected]>
* Updated FlakyTestAttribute to allow retries * Updated attribute comment based on feedback * Loggin attempt with TestExecutionContext.CurrentResult * Avoid static var * [housekeeping] Automated PR to fix formatting errors on update-flakytestattribute * Fix build errors --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update copilot-setup-steps.yml to add the local dotnet to PATH * Update copilot-setup-steps.yml * Update copilot-setup-steps.yml * Update copilot-setup-steps.yml * Update copilot-setup-steps.yml
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* added sample and test class files * Added android snap * Updated images for android and ios * Update CorePageView.cs * updated base images for windows and catalyst platform * removed unused references
) * Don’t call NSAttributedString with HTML from a background thread * Added a UITest * Refactor * add more comments and move to Controls --------- Co-authored-by: Matthew Leibowitz <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#29371) * Fixed the shadow transparent issue on android * Updated the fix. * Added the test case and updated the fix * Added the output images. * Updated the fix. * Updated the comment. * Added the output images for mac and Windows * Updated the test case and added output images. * Added the output images
* ToolbarItem behavior with ImageSource iOS - fix * Added snapshots
* Update the comment for the test properties * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> * Update src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs Co-authored-by: Rui Marinho <[email protected]> * Update src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs * Update BaseBuildTest.cs --------- Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <[email protected]> Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Dhivya-SF4094 <[email protected]> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <[email protected]> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: Tamilarasan Paranthaman <[email protected]> Co-authored-by: NafeelaNazhir <[email protected]> Co-authored-by: Paul Anderson <[email protected]> Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Dhivya-SF4094 <[email protected]> Co-authored-by: devanathan-vaithiyanathan <[email protected]> Co-authored-by: Subhiksha Chandrasekaran <[email protected]> Co-authored-by: BagavathiPerumal <[email protected]> Co-authored-by: prakashKannanSf3972 <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: SuthiYuvaraj <[email protected]> Co-authored-by: SyedAbdulAzeemSF4852 <[email protected]> Co-authored-by: Anandhan Rajagopal <[email protected]> Co-authored-by: Bhavanesh N <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>
* Fixed ItemSpacing on CarouselView * Added snapshot for Android and Mac * Resaved image for CarouselViewShouldRenderCorrectly
* FeatureMatrix for stepper control * Added the snapshot for windows platform * Updated StepperFeatureTests.cs * Updated StepperControlPage.xaml
…Feature (#29322) * added ItemsSource feature Tests * modified changes * updated changes * Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs Co-authored-by: Copilot <[email protected]> * modified changes * added snapshots * modified changes * modified changes * modified changes --------- Co-authored-by: Copilot <[email protected]>
…nView in the SelectionChanged event does not clear the selection (#29288) * Fix for 10025 (Setting the CollectionView's SelectedItem to null on selection changed event does nothing) * Have added the test case * Have added the snapshots
… rotate your screen. (#29171) * fix-15154-Added proper Auto Layout constraints to ensure content wraps instead of truncating in landscape mode. * fix-15154-Prepared the testcase and snapshot added for android and iOS. * fix-15154-Modified the test condition. * fix-15154-Modified the code to align the edges of ContentView with the edges of platformView. * fix-15154-Adjusted inset constraints to respect view margins in FlyoutItem and updated Android snapshot. * fix-15154-Replaced individual .Active=true calls with batch NSLayoutConstraint.ActivateConstraints() for better performance with Shell flyout margins.
* Weak subscription to CanExecuteChange events * - add tests * - fix lifecycle of CanExecute subscription * - cleanup code based on Pictos recommendations * - add a netstandard_20 version of DependentHandle * - add more * - fix missing null check on textcell
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…raphicsView (#30007) * [iOS] Fix for downsized image retains original size * Renamed variables for better readability
* make picker not focisable # Conflicts: # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt * Address review comments * set keylistner to null * Make sure Focus()/Unfocus() works * Address review comments * Remove IsFocused Checks
* Reverting the OnMeasure changes and 27614 test cases * Resaved the Android images * Change in unshipped file
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…resizing when bounds change (#29639) * Fix CV1 empty view not resizing when bounds change and grid layout not left aligning single item * - rework test * - fix test --------- Co-authored-by: Shane Neuville <[email protected]>
#30136) * Resaved the Snapshots * Update ImagePaintWithDownsize.png * update mac image * Updated test failures * Added mac and windows images from CI --------- Co-authored-by: Anandhan Rajagopal <[email protected]>
* Added-28051-Test * Removed-keyword * Added-Test-For-All-Platforms
…in HostApp (#30272) * [housekeeping] Dispatch MainPage reset to UI thread in HostApp * spacing
… property does not update text in the search box (#28400)" (#30250) * Revert "[Android, iOS] Dynamically setting SearchHandler Query property does not update text in the search box (#28400)" This reverts commit 559da79. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue14497.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14497.cs * Revert "[Android & iOS] Fix for SearchHandler Character Spacing Property (#29497)" This reverts commit 9827339. # Conflicts: # src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs # src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs # src/Controls/tests/TestCases.HostApp/Issues/Issue29492.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29492.cs * - remove character spacing
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - Inflight/Candidate Branch ## What's Changed ### MAUI Product Fixes * [iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fixes #26863 by @kubaflo in #26868 * Fixes Setting BackgroundColor to null does not actually changes BackgroundColor - fixes #22914 and #19576 by @jgonzalez-gft in #22917 * Fixed the picker title's color - fixes #16737 by @kubaflo in #23075 * [android] Fallback to default icons in SearchHandler by @aheubusch in #25067 * ScrollView's Background on iOS - fixes #24016 by @kubaflo in #25541 * [iOS] Enabled MultiTouch Support for Handling Multi-Touch Points in GraphicsView - fixes #29461 by @prakashKannanSf3972 in #29895 * Optimize converters for GridLength, ColumnDefinition, and RowDefinition - performance improvement by @emiller in #20048 * Add defensive IsAlive check to Android ViewExtensions.OnUnloaded - fixes #28051 by @jfversluis in #29934 * [Windows] Fixed runtime update issue for SearchBar PlaceholderColor and BackgroundColor - fixes #29962 by @Tamilarasan-Paranthaman in #29965 * Weak subscription to CanExecuteChange events - fixes #16124 by @sneumaier in #29837 * [iOS, Mac] Fix for downsized image retaining original dimensions in GraphicsView - fixes #30006 by @SyedAbdulAzeemSF4852 in #30007 * [Android] Prevent Picker from Gaining Focus on Touch - fixes #19739, #8546, #13503, #24862, #28121, #21704, #15394 by @bhavanesh2001 in #29068 * Fix CV1 GridItemsLayout centering single item AND Fix Empty view not resizing when bounds change - fixes #29595, #29634 by @albyrock87 in #29639 ### Testing * [Testing] Feature Matrix UITest Cases for Button by @TamilarasanSF4853 in #29803 * [Testing] Feature matrix UITest Cases for BoxView Control by @HarishKumarSF4517 in #29808 * [Testing] Enable HandlerDoesNotLeak for Button and ProgressBar by @bhavanesh2001 in #29896 * [Testing] Add Validation Test For Issue28051 On Android by @prakashKannanSf3972 in #30026 * [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate by @HarishKumarSF4517 in #30136 ### Dependency Updates * Bump to 1.7.250606001 of WindowsAppSDK by @sneumaier in #29915 ### Housekeeping * [housekeeping] Update namespaces in HostApp and Shared tests projects by @bhavanesh2001 in #29904 * Update SetterSpecificity.cs Remove Extra Line From Bad Merge by @sneumaier in #29987 * Revert - Fixed the Label not sized correctly on Android by @Ahamed-Ali in #30023 * Revert "Fixes Setting BackgroundColor to null does not actually changes BackgroundColor #22914 (#22917)" by @mattleibow in #30031 * [create-pull-request] automated change by @github-actions[bot] in #30019 * [create-pull-request] automated change by @github-actions[bot] in #30043 * [create-pull-request] automated change by @github-actions[bot] in #30078 * Update Controls.TestCases.HostApp.csproj by @HarishKumarSF4517 in #30124 ## New Contributors * @albyrock87 made their first contribution in #29639 * @SyedAbdulAzeemSF4852 made their first contribution in #30007 * @emiller made their first contribution in #20048 * @jgonzalez-gft made their first contribution in #22917 * @aheubusch made their first contribution in #25067 **Full Changelog**: https://github.com/dotnet/maui/compare/main..inflight/candidate
# Conflicts: # .config/dotnet-tools.json # .github/copilot-instructions.md # eng/Version.Details.xml # eng/Versions.props # eng/common/core-templates/job/source-index-stage1.yml # eng/common/core-templates/steps/source-build.yml # eng/common/post-build/publish-using-darc.ps1 # eng/devices/android.cake # global.json # src/Controls/src/Core/Cells/TextCell.cs # src/Controls/src/Core/ColumnDefinitionCollectionTypeConverter.cs # src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt # src/Controls/src/Core/RowDefinitionCollectionTypeConverter.cs # src/Controls/src/Xaml/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Xaml/PublicAPI/netstandard/PublicAPI.Unshipped.txt # src/Controls/tests/TestCases.Android.Tests/snapshots/android/ImagePaintWithDownsize.png # src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/CollectionView_GroupingFeatureTests.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10025.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Downsize.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Resize.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.cs # src/Core/src/Platform/Windows/SearchBarExtensions.cs # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/net/PublicAPI.Unshipped.txt # src/Essentials/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt # src/Graphics/src/Graphics/Platforms/Windows/PlatformImage.cs # src/Templates/src/cgmanifest.json # src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs # src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs
### Description of Change Bring latest changes from main to net10.0 branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
Merges the latest .NET 10.0 changes into the preview 6 branch, updating UI tests, host app issue samples, and core control implementations.
- Standardized namespace declarations and formatting across shared tests and host app samples.
- Expanded and hardened UI test cases (replacing sleeps with waits, adding retry logic).
- Updated core controls to use weak command subscriptions and added lifecycle overrides for binary compatibility.
Reviewed Changes
Copilot reviewed 219 out of 427 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.cs | Replaced Thread.Sleep calls with explicit WaitForElement and added TapWithRetriesUntilElementReady. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29634.cs | New issue sample for empty-view resizing using modern C# collection expressions and updated namespace. |
| src/Controls/src/Core/TemplatedView/TemplatedView.cs | Added MeasureOverride, ArrangeOverride, and OnSizeAllocated overrides to preserve binary compatibility. |
| src/Controls/src/Core/RowDefinitionCollectionTypeConverter.cs | Refactored parsing to use ArrayPool<string> for improved performance and memory usage. |
| src/Controls/src/Core/Shell/SearchHandler.cs | Switched direct CanExecuteChanged subscriptions to use WeakCommandSubscription for automatic cleanup. |
Comments suppressed due to low confidence (2)
src/Controls/src/Core/TemplatedView/TemplatedView.cs:133
- Since this public override was added for binary compatibility, please update the XML reference documentation under
/docs/to include the newMeasureOverride,ArrangeOverride, andOnSizeAllocatedmethods.
protected override Size MeasureOverride(double widthConstraint, double heightConstraint)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8870.cs:47
- Ensure that the
#if/#endifpreprocessor directives correctly enclose the entire file after removing the extra closing brace; otherwise this may lead to compilation errors or unexpected code being excluded.
#endif
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Bring latest changes to net10.0 preview 6 release branch