[Testing] Enable UITest Issue18193 on MacCatalyst #31653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This pull request enables the Issue18193 UI test on MacCatalyst by removing the platform exclusion directive and updating button naming for better clarity and consistency. The changes aim to resolve CI reliability issues that were preventing this test from running on Catalyst platforms.
Key Changes:
- Removed
#if TEST_FAILS_ON_CATALYSTdirective to enable the test on MacCatalyst - Updated button variable names and
AutomationIdproperties for improved clarity and consistency - Fixed type references in Shell content creation to use correct page types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18193.cs |
Removed platform exclusion directive and updated test to use new AutomationId values |
src/Controls/tests/TestCases.HostApp/Issues/Issue18193.cs |
Updated button variable names, AutomationId properties, and fixed Shell content type references |
Comment on lines
+18
to
+24
| tabBar.Items.Add(CreateShellContent("Page 7", typeof(Issue18193Page7), nameof(Issue18193Page7))); | ||
| tabBar.Items.Add(CreateShellContent("Page 8", typeof(Issue18193Page8), nameof(Issue18193Page8))); | ||
| tabBar.Items.Add(CreateShellContent("Page 9", typeof(Issue18193Page9), nameof(Issue18193Page9))); | ||
| tabBar.Items.Add(CreateShellContent("Page 10", typeof(Issue18193Page10), nameof(Issue18193Page10))); | ||
| tabBar.Items.Add(CreateShellContent("Page 11", typeof(Issue18193Page11), nameof(Issue18193Page11))); | ||
| tabBar.Items.Add(CreateShellContent("Page 12", typeof(Issue18193Page12), nameof(Issue18193Page12))); | ||
| tabBar.Items.Add(CreateShellContent("Page 13", typeof(Issue18193Page13), nameof(Issue18193Page13))); |
There was a problem hiding this comment.
The referenced page types (Issue18193Page7 through Issue18193Page13) do not exist in the codebase. This will cause compilation errors when these types are referenced in the CreateShellContent calls.
Copilot uses AI. Check for mistakes.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Sep 18, 2025
| @@ -17,19 +16,18 @@ public Issue18193(TestDevice testDevice) : base(testDevice) | |||
| [Category(UITestCategories.Shell)] | |||
| public void ShellNavigationShouldWorkInMoreTab() | |||
There was a problem hiding this comment.
ShellNavigationShouldWorkInMoreTab is gaining on Mac:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2530
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2547
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, IQuery query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 777
at UITest.Appium.HelperExtensions.WaitForElementTillPageNavigationSettled(IApp app, String elementId, Nullable`1 timeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2181
at Microsoft.Maui.TestCases.Tests.Issues.Issue18193.ShellNavigationShouldWorkInMoreTab() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18193.cs:line 23
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR reopens the work from the closed PR #28210
This pull request introduces multiple updates to the
Issue18193test cases. The main changes focus on renaming button variables and theirAutomationIdproperties to enhance clarity and consistency, along with minor refactoring aimed at resolving reliability issues on Catalyst platforms within CI environments. Although the specific cause of the ongoing CI failures has not been conclusively identified, these modifications tackle frequent issues that can impact UI test reliability on Catalyst platforms.Test updates:
Removed the
#if TEST_FAILS_ON_CATALYSTdirective and the related comment from theIssue18193test file.Updated the test steps in the
ShellNavigationShouldWorkInMoreTabmethod to use the newAutomationIdvalues for button interactions.Issues Fixed
Fixes #27206