Candidate Branch September 22nd #31681

PureWeen · 2025-09-18T18:30:20Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Issues Fixed

Fixes #

Copilot

Pull Request Overview

This PR adds comprehensive test cases for various .NET MAUI controls, including new issue reproductions and feature matrix test pages. The changes primarily focus on expanding the test coverage for UI controls and their properties, with particular emphasis on navigation, layout controls, and visual elements.

Issue test cases: Adds test cases for 10 new issues covering FlyoutPage, RefreshView, CollectionView, LinearGradientBrush, PointerGestureRecognizer, Shell, and navigation scenarios
Feature matrix pages: Introduces comprehensive test pages for WebView, TwoPaneView, SwipeView, Shapes, RefreshView, NavigationPage, HorizontalStackLayout, FlyoutPage, and ContentView controls
Test infrastructure: Adds ViewModels, options pages, and supporting classes to enable thorough testing of control properties and behaviors

Reviewed Changes

Copilot reviewed 81 out of 723 changed files in this pull request and generated 4 comments.

File	Description
src/Controls/tests/TestCases.HostApp/Issues/*.cs	Issue reproduction test cases for various UI controls and navigation scenarios
src/Controls/tests/TestCases.HostApp/Issues/Issue30483.xaml*	XAML-based Shell FlyoutMenu test case
src/Controls/tests/TestCases.HostApp/FeatureMatrix//.cs	ViewModels and code-behind for comprehensive control testing
src/Controls/tests/TestCases.HostApp/FeatureMatrix//.xaml	XAML UI definitions for feature matrix test pages

Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.HostApp/FeatureMatrix/Shapes/ShapeConverters.cs:1

The cast ((Issue31351CollectionViewItem)this) is unnecessary and should be this.Title.Equals(...)

using System.Globalization;

src/Controls/tests/TestCases.HostApp/FeatureMatrix/NavigationPage/NavigationPageControlPage.xaml.cs:1

[nitpick] Creating a new ViewModel instance discards the existing state and navigation tracking. Consider whether this is intentional or if state should be preserved.

using System;

Copilot · 2025-09-18T18:31:26Z

src/Controls/tests/TestCases.HostApp/Issues/Issue31390.cs

+	Issue31390ViewModel _viewModel;
+	public Issue31390FlyoutPage(Issue31390ViewModel _viewModel)
+	{
+		_viewModel = new Issue31390ViewModel();


The parameter _viewModel passed to the constructor is ignored, and a new instance is created instead. This should use the passed parameter: this._viewModel = _viewModel;

Suggested change

_viewModel = new Issue31390ViewModel();

this._viewModel = _viewModel;

Copilot · 2025-09-18T18:31:27Z

src/Controls/tests/TestCases.HostApp/Issues/Issue31390.cs

+
+	private async void NavigateToPopover_Clicked(object sender, EventArgs e)
+	{
+		BindingContext = _viewModel = new Issue31390ViewModel();


Creating a new ViewModel instance here discards any state from the existing _viewModel. This should likely reuse the existing instance or ensure state is properly transferred.

Suggested change

BindingContext = _viewModel = new Issue31390ViewModel();

BindingContext = _viewModel;

Copilot · 2025-09-18T18:31:28Z

...s/tests/TestCases.HostApp/FeatureMatrix/HorizontalStackLayout/StackLayoutControlPage.xaml.cs

+
+	private async void NavigateToOptionsPage_Clicked(object sender, EventArgs e)
+	{
+		BindingContext = _viewModel = new StackLayoutViewModel();


[nitpick] Creating a new ViewModel instance discards any existing property values. This pattern appears multiple times and may not preserve user-configured settings.

Suggested change

BindingContext = _viewModel = new StackLayoutViewModel();

// Reuse the existing _viewModel to preserve property values

Copilot · 2025-09-18T18:31:28Z

src/Controls/tests/TestCases.HostApp/FeatureMatrix/Shapes/ShapesControlPage.xaml.cs

+
+	private async void NavigateToOptionsPage_Clicked(object sender, EventArgs e)
+	{
+		BindingContext = _viewModel = new ShapesViewModel();


[nitpick] Creating a new ViewModel instance discards any existing shape configuration. Consider preserving state or documenting that this is intentional reset behavior.

Suggested change

BindingContext = _viewModel = new ShapesViewModel();

// Preserve existing shape configuration by reusing the current _viewModel

PureWeen · 2025-09-18T21:01:21Z

/rebase

PureWeen · 2025-09-18T22:05:36Z

@kubaflo it looks like CurrentItemShouldWork is failing

kubaflo · 2025-09-18T23:08:48Z

@kubaflo it looks like CurrentItemShouldWork is failing

Can we try to azp this PR?
#31685

sheiksyedm · 2025-09-19T13:02:24Z

@kubaflo These tests failed with this PR changes. Can you look at it?

TitleView_Add_Visual
TitleIcon_And_TitleView_Persist_On_Push_Then_Clear (see overlaping on icon and title).

kubaflo · 2025-09-20T00:09:27Z

@kubaflo These tests failed with this PR changes. Can you look at it?

TitleView_Add_Visual

TitleIcon_And_TitleView_Persist_On_Push_Then_Clear (see overlaping on icon and title).

#31701

PureWeen · 2025-09-23T03:53:42Z

/rebase

PureWeen · 2025-09-23T16:01:05Z

/rebase

* [Android] Sort gradient stops by offset Updated the gradient stop processing to order stops by their offset before populating color and offset arrays. This ensures gradients are rendered correctly according to stop positions. * Added a UITest * Add snapshots --------- Co-authored-by: Gerald Versluis <[email protected]>

…aded event while navigating on MacCatalyst and iOS (#29410) * Fixed Crash on shell navigation for Mac Catalyst * Test case added * test case name modified * updated the fix * Issue linked * curly brace added * modified the condition. * Modified the fix

* added test cases * updated test cases * updated ui * added test cases * added failing condition * added Android and iOS snapshots * added snapshots * removed VerifyScreenshot * added additional test case * added mac snapshot * modified ProgressSpinnerNotDisabledOnStartup test case * Replaced DragCoordinates with the ScrollUp method

* feature_matrix_twopaneview * Updated TwoPaneViewFeatureTest * Updated TwoPaneView Feature matrix * Update TwoPaneViewFeatureTests.cs * Added properties * Added the Snapshots * Updated Two Pane View * Added Snapshots * Added snapshots * Added snapshots for windows * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update TwoPaneViewFeatureTests.cs --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>

* Added WebView Feature Tests * Added base image * Updated the test case --------- Co-authored-by: Shane Neuville <[email protected]>

* added the sample and test class files * added snapshot for iOS and android * added FailsOn attributes * updated * test case modified * changes updated * revert this changes * added snapshot from CI * update copilot suggestion * update test case --------- Co-authored-by: Shane Neuville <[email protected]>

* harish_feature_matrix_border * Update BorderFeatureTests.cs * Updated BorderFeatureTest.cs * Update BorderFeatureTests.cs * Added Shapes for Border Control * Updated the TestCases * Added Snapshots * Updated the SnapShots * Added Fails to the Testcase * Update BorderFeatureTests.cs * Update BorderFeatureTests.cs * Updated the Windows Snapshots

* Added Flyout Feature tests * changes updated * Added base images * Added base images * changes updated * Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/FlyoutPage/FlyoutPageViewModel.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/FlyoutPageFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/FlyoutPageFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Addressed copilot suggestions --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>

* ContentPage_Feature_Matrix * Added Testcases * Added Testcases * Added snapshots * Updated the testcase * Update src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/ContentPageFeatureTests.cs Co-authored-by: Copilot <[email protected]> * Added snapshots * Updated the Android and iOS snapdhots --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Shane Neuville <[email protected]>

…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues

…eshing is set to True (#31471) * fix added * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * Update RefreshViewHandler.Windows.cs * test case added * Update RefreshViewHandler.Windows.cs * Update Issue31375.cs * Update Issue31375.cs

…splay selection correctly (#31549) * Update ItemsViewHandler.Windows.cs * Testcases added * commit for testcases * Update Issue31351.cs * Update Issue31351.cs * Update Issue31351.cs

* Added sample class files * updated sample * added test case * updated UI * updated * updated test cases * updated snapshot for iOS * added issue link * added CI snapshots --------- Co-authored-by: Shane Neuville <[email protected]>

* AbsoluteLayout Feature tests * Added base images * Added base images --------- Co-authored-by: Shane Neuville <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Added the testbed sample for the NavigationPage Feature Matrix * Added the testcases for NavigationPage * Updated NavigationPageFeatureTests * Added the Snapshots * Added snapshots for mac and windows * Updated the testcases * Update NavigationPageFeatureTests.cs * Update NavigationPageFeatureTests.cs * Added Windows and Mac snapshots * Update TitleViewCleared.png --------- Co-authored-by: nivetha-nagalingam <[email protected]>

…ck Layout (#31393) * Added snapshots * Updated tests * Removed snapshots * Added Snapshots * Added base images * Updated the suggestions * Added the Snapshots --------- Co-authored-by: Shane Neuville <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Added UI test for null selectin bug * Handle when group update changes to no values * Added unit test * new file to file scoped namespace * Ignore child added if layout is null * Piggy backed off of existing UI sample * removing unused using * reverting whitespace * removing unused using * Have RadioButton default to itself for uniqueness * Added comment justifying madness * less hacky way * Less hacky and added unit test --------- Co-authored-by: Evin Ballantyne <[email protected]>

* Update NavigationRenderer.cs * test case added * Update Issue31539.cs * snapshot added

…azor Maui Web template"" (#31677)

…causes back button to disappear (#28132) * [Android] Shell.BackButtonBehavior - improvement * Added a UITest * Updated snapshots

* Misc nativeAOT Windows compatibility fixes * Adjust conditional for font retrieval in FontManager.Windows * Revert ShellItemHandler changes and update MauiNavigationView with dynamic dependencies

…ushAsync (#31536) * Update NavigationPage.cs * Added test * Update NavigationPage.cs * Update NavigationPage.cs

* revert * test

) * [CarouselViewHandler2] CurrentItem does not work when PeekAreaInsets is set * Added a UITest

)

…31701) * [iOS] Shell/NavigationPage TitleView Replaces the custom CalculateUIEdgeInsets method with an override of AlignmentRectInsets that leverages the IView.Margin property. This ensures the alignment insets reflect the view’s actual margins, allowing developers to align the TitleView directly with the screen edges. * [iOS] Shell/NavigationPage TitleView Replaces the custom CalculateUIEdgeInsets method with an override of AlignmentRectInsets that leverages the IView.Margin property. This ensures the alignment insets reflect the view’s actual margins, allowing developers to align the TitleView directly with the screen edges.

PureWeen · 2025-09-24T01:49:14Z

The PR CI is having trouble starting the API 33 devices

I ran on an internal pipeline here
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12448437&view=results

and it's all green

Copilot AI review requested due to automatic review settings September 18, 2025 18:30

Copilot AI reviewed Sep 18, 2025

View reviewed changes

PureWeen force-pushed the inflight/candidate branch from f206b73 to 9d33434 Compare September 18, 2025 19:00

PureWeen changed the title ~~Inflight/candidate~~ Candidate Branch September 22nd Sep 18, 2025

github-actions bot force-pushed the inflight/candidate branch from b16945f to 56e935e Compare September 18, 2025 21:02

kubaflo mentioned this pull request Sep 18, 2025

Candidate branch september 22nd current item should work test fix #31685

Merged

NafeelaNazhir mentioned this pull request Sep 19, 2025

[Testing] Fixed Test case failure in PR 31681 - [09/22/2025] Candidate #31696

Merged

kubaflo mentioned this pull request Sep 20, 2025

[iOS] Shell/navigation page title view - respect the margin property #31701

Merged

NafeelaNazhir mentioned this pull request Sep 22, 2025

[Testing] Fixed Test case failure in PR 31681 - [09/22/2025] Candidate2 #31712

Merged

github-actions bot force-pushed the inflight/candidate branch from 1e4c148 to 81eebe5 Compare September 23, 2025 03:54

NafeelaNazhir mentioned this pull request Sep 23, 2025

[Testing] Fixed Test case failure in PR 31681 - [09/22/2025] Candidate3 #31723

Merged

MartyIX and others added 12 commits September 23, 2025 16:01

Optimize (#31429)

18bcc71

[Testing] Feature matrix UITest Cases for WebView Control (#30517)

2bae892

* Added WebView Feature Tests * Added base image * Updated the test case --------- Co-authored-by: Shane Neuville <[email protected]>

[Windows] Test inclusion for the PointerGestureRecognizer issue in Mu…

19c78cc

…ltiWindow. (#31143) * Included the test for the PointerGesture Issue on windows * Used Windows API for minimizing the window * Minimize the window using GetWindowHandle * prevent unwanted issues

Dhivya-SF4094 and others added 22 commits September 23, 2025 16:01

Fixed exception when setting FlyoutLayoutBehavior dynamically (#31491)

3c97810

Fix Customised CollectionView inherited from does not ScrollTo and di…

c39b8c4

…splay selection correctly (#31549) * Update ItemsViewHandler.Windows.cs * Testcases added * commit for testcases * Update Issue31351.cs * Update Issue31351.cs * Update Issue31351.cs

[Testing] Feature matrix UITest Cases for AbsoluteLayout (#31517)

cdacfcf

* AbsoluteLayout Feature tests * Added base images * Added base images --------- Co-authored-by: Shane Neuville <[email protected]>

[create-pull-request] automated change (#31576)

cf2bd9a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[create-pull-request] automated change (#31599)

446a059

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Compilation issue resolved on inflight/current branch (#31675)

073c3a6

[iOS] Fix Navigation Page BackButtonTitle Not Updating (#31583)

ddafd27

* Update NavigationRenderer.cs * test case added * Update Issue31539.cs * snapshot added

Revert "Revert "Replace UseStaticFiles() with MapStaticAssets() in Bl…

d682bba

…azor Maui Web template"" (#31677)

[Android] Shell BackButtonBehavior binding Command to valid ICommand …

5e9f56b

…causes back button to disappear (#28132) * [Android] Shell.BackButtonBehavior - improvement * Added a UITest * Updated snapshots

Misc nativeAOT Windows stability adjustments (#31274)

1926e1a

* Misc nativeAOT Windows compatibility fixes * Adjust conditional for font retrieval in FontManager.Windows * Revert ShellItemHandler changes and update MauiNavigationView with dynamic dependencies

[Android,Windows] Fix NavigatingFrom event order inconsistency with P…

3990526

…ushAsync (#31536) * Update NavigationPage.cs * Added test * Update NavigationPage.cs * Update NavigationPage.cs

[Windows] Revert cleanup of AccessibilityExtensions (#31608)

261b5db

* revert * test

[iOS] CurrentItem does not work when PeekAreaInsets is set - fix (#29995

2088140

) * [CarouselViewHandler2] CurrentItem does not work when PeekAreaInsets is set * Added a UITest

Candidate Branch September 22nd - CurrentItemShouldWork test fix (#31685

1c3b20b

)

Added base images (#31696)

8504272

Added images (#31712)

eedcef3

crop the images (#31723)

793f2e8

github-actions bot force-pushed the inflight/candidate branch from 68ab300 to 793f2e8 Compare September 23, 2025 16:01

PureWeen enabled auto-merge September 23, 2025 20:37

mattleibow approved these changes Sep 23, 2025

View reviewed changes

PureWeen disabled auto-merge September 24, 2025 01:48

PureWeen merged commit 32458cc into main Sep 24, 2025
128 of 130 checks passed

PureWeen deleted the inflight/candidate branch September 24, 2025 01:50

sheiksyedm mentioned this pull request Sep 24, 2025

[Testing] Fixed Test case failure in main branch #31733

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Candidate Branch September 22nd #31681

Candidate Branch September 22nd #31681

PureWeen commented Sep 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

Copilot AI Sep 18, 2025

Uh oh!

PureWeen commented Sep 18, 2025

Uh oh!

PureWeen commented Sep 18, 2025

Uh oh!

kubaflo commented Sep 18, 2025

Uh oh!

sheiksyedm commented Sep 19, 2025

Uh oh!

kubaflo commented Sep 20, 2025

Uh oh!

PureWeen commented Sep 23, 2025

Uh oh!

PureWeen commented Sep 23, 2025

Uh oh!

PureWeen commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

	_viewModel = new Issue31390ViewModel();
	this._viewModel = _viewModel;

	BindingContext = _viewModel = new Issue31390ViewModel();
	BindingContext = _viewModel;

	BindingContext = _viewModel = new StackLayoutViewModel();
	// Reuse the existing _viewModel to preserve property values

	BindingContext = _viewModel = new ShapesViewModel();
	// Preserve existing shape configuration by reusing the current _viewModel

Candidate Branch September 22nd #31681

Candidate Branch September 22nd #31681

Conversation

PureWeen commented Sep 18, 2025

Description of Change

Issues Fixed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

PureWeen commented Sep 18, 2025

Uh oh!

PureWeen commented Sep 18, 2025

Uh oh!

kubaflo commented Sep 18, 2025

Uh oh!

sheiksyedm commented Sep 19, 2025

Uh oh!

kubaflo commented Sep 20, 2025

Uh oh!

PureWeen commented Sep 23, 2025

Uh oh!

PureWeen commented Sep 23, 2025

Uh oh!

PureWeen commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!