-
Couldn't load subscription status.
- Fork 1.2k
CLI --self-contained description is wrong #51088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.1xx
Are you sure you want to change the base?
Conversation
|
@adegeo you'll need to update the xlf files on your fork to bump the translations. After that, you'll probably need to update the CLI snapshot tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great call out. By default, I didn't mean the value of the command argument but the value of the SelfContained property itself. SelfContained itself is 'false' by default (with no argument) but providing --self-contained makes it true. I don't think we need this breaking change string at this point.
|
@baronfel I removed the lines from the translation files. I don't know what to do about the other item you said. |
|
Thank you @adegeo for driving the extra effort to fix the files and improve our docs by making a PR. And to @baronfel for adding help context. I don't think we should expect our doc writers to be able to fix the tests on our repo. This should really be an automatable process and it is not a valuable use of human time/energy to fix either the xlf files or the completions snapshots. I've created #51157 to see if the bot can write something to teach itself to do these tasks for us. |
|
@nagilson I assume this isn't for GA so we probably need to backport to 2xx or retarget to 2xx (whichever works). |
It looks like #32656 updated the
--self-containeddescription incorrectly. The code change that triggered the old PR was actually related to the --runtime parameter no longer enforcing self-contained=true. It had nothing to do with the --self-contained option itself.--self-contained is an option argument type and defaults to true when passed.
@baronfel